docs: update per-org removal plan for immediate-removal decision - #5995
docs: update per-org removal plan for immediate-removal decision#5995ralphbean wants to merge 2 commits into
Conversation
The team decided to skip the phased deprecation (warnings + migration command) and remove per-org support immediately and completely in a single effort (#2302, meeting update 2026-08-06), rather than the two-phase rollout ADR-0044 originally described. Drop the Phase 1 deprecation-warning/migration-command PRs (formerly PRs 1-5) from the implementation plan and renumber the removal-only PRs (formerly Phase 2, PRs 6-15) to 1-10. Update the dependency graph, context, and release checklist to match. Cross-reference #5990 for the e2e suite conversion tracked separately. ADR-0044 itself still documents the original phased decision; see #2302 for the updated decision context. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
PR Summary by QodoDocs: revise per-org removal plan to reflect immediate removal decision
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1.
|
waynesun09
left a comment
There was a problem hiding this comment.
Review-only pass (not self-assigning, approving, or requesting changes). Left 3 inline comments on docs/plans/deprecate-per-org-install.md. One additional finding below is on a file this PR doesn't touch, so it can't be anchored inline:
MEDIUM: ADR-0044 §2 "Implementation plan" now cross-references a stale, mismatched PR list (docs/ADRs/0044-deprecate-per-org-installation-mode.md, §2, around line 352)
This PR touches only docs/plans/deprecate-per-org-install.md; ADR-0044 is untouched. ADR-0044 §2 still says the companion plan doc "contains a 15-PR dependency graph" and enumerates "Phase 1 (5 PRs)" plus "Phase 2 (10 PRs)" numbered 6-15 (e.g. "PR 10: Remove org-level forge methods", "PR 15: Remove per-org e2e tests..."). This PR renumbers the plan doc to a flat 1-10 scheme and deletes Phase 1 entirely (removed "### PR 2: Update documentation", "### PR 3: Add per-repo e2e test", the Phase 1/Phase 2 headers, and the old dependency graph). The ADR's detailed, number-matched PR list is now factually wrong versus the plan doc it explicitly points readers to, not just stale prose in the Decision section (which the PR body's disclaimer does address). A reader following ADR-0044 §2's numbering into the plan doc will find PR numbers/content that no longer correspond (e.g., ADR's "PR 10: forge methods" vs. plan doc's "PR 5: forge methods").
Suggestion: add a one-line annotation under ADR-0044 §2 (using the ADR's own stated convention for minor cross-reference annotations) noting the detailed PR list has been superseded by the renumbered, Phase-1-dropped plan in docs/plans/deprecate-per-org-install.md, so readers don't cross-reference stale PR numbers between the two documents. Separately, since ADR-0044's Decision section materially changed (two-phase rollout -> immediate single-phase removal), consider opening a tracking issue for a formal ADR supersession/amendment rather than leaving that as an open question only in the PR body.
- Retitle the plan doc's H1 to match the removal-only scope (was still "Deprecate...") - Add manual-migration guidance for existing per-org installs, since dropping the migrate command leaves no automated path - Narrow the #5990 e2e-conversion caveat to the lifecycle test only; clarify lock_test.go/cleanup.go proceed independently - Add an explicit docs-update task to PR 10 covering org-mode.md, architecture.md, and a guides sweep - Annotate ADR-0044 §2 as superseded by the plan doc's renumbering Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 4:24 PM UTC · Completed 4:43 PM UTC Commit: |
|
Re: #5995 (review) Good point. Pushed d10acf1 — added an update note under ADR-0044 §2 flagging it as superseded by the plan doc's renumbering, following the same pattern as ADR-0067's update note. Didn't open a tracking issue for a formal ADR supersession — that feels like a separate conversation to have with the team, happy to file one if it'd help. |
|
Re: #5995 (comment) Same title issue flagged inline — fixed in d10acf1. |
|
Closing this one. While it was open, #5972 deleted #2302 stays open — the actual per-org removal hasn't happened, we just lost the place to track a per-file implementation plan for it. Whoever picks it up next will want a different vehicle for the checklist, maybe a tracking issue with subtasks instead of a markdown plan. |
|
🤖 Finished Retro · ✅ Success · Started 4:31 PM UTC · Completed 5:18 PM UTC Commit: |
|
Review skipped — this PR is already closed. The Posted by fullsend post-review check |
Retro: PR #5995 — docs: update per-org removal planAgents repo discovered: Timeline
ObservationsSilently dropped webhook (novel finding): The Evidence for existing issues (no new proposals warranted):
Autonomy readinessNo meaningful agent-vs-human comparison is possible. The human reviewer (waynesun09) reviewed commit 1 and found 4 real issues. The review agent only ran on commit 2 (which incorporated the human's fixes) and never posted its findings. The review agent's run logs show it analyzed ADR cross-reference staleness and phase-skip intent coherence — suggesting it may have caught similar issues on the original content — but this cannot be validated. Proposals filed
|
Summary
docs/plans/deprecate-per-org-install.md, and renumbers the removal-only PRs (formerly Phase 2, PRs 6-15) to 1-10.Note: ADR-0044 itself still documents the original phased decision — this PR only updates the implementation plan doc, not the ADR (per this repo's convention that ADR decision sections aren't rewritten in place). Whether ADR-0044 needs a formal update/supersession is a separate question worth raising with the team.
Test plan
make lint-md-linkspasses