Skip to content

chore(#6228): add qodo pr-agent config to disable stale Go test rules - #6230

Merged
ralphbean merged 1 commit into
mainfrom
agent/6228-disable-stale-qodo-rules
Aug 21, 2026
Merged

chore(#6228): add qodo pr-agent config to disable stale Go test rules#6230
ralphbean merged 1 commit into
mainfrom
agent/6228-disable-stale-qodo-rules

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Add a .pr_agent.toml repo-level configuration file to disable qodo-code-review convention pack rules TC-001 and TC-002, which mandate stdlib-only Go testing (no testify). The project uses testify/assert and testify/require in 72% of test files, making these rules a standing source of false-positive findings on Go test PRs.

Related Issue

Closes #6228

Changes

  • Add .pr_agent.toml with [pr_reviewer] and [pr_code_suggestions] sections
  • Both sections include extra_instructions telling qodo to skip TC-001/TC-002 enforcement and not suggest replacing testify with stdlib assertions
  • Configuration follows qodo's repo-level config format, overriding only the relevant settings

Testing

  • TOML syntax validated (Python tomllib)
  • Secret scan passed
  • Verify on next Go test PR: qodo-code-review should produce zero TC-001/TC-002 findings

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Commits are signed off (DCO) — human and human-directed agent sessions only
  • I wrote this contribution myself and can explain all changes in it

Note: pre-commit could not run in the sandbox (network restriction on git fetch for hook environment setup). The post-script runs pre-commit authoritatively on the runner.


Closes #6228

Post-script verification

  • Branch is not main/master (agent/6228-disable-stale-qodo-rules)
  • Secret scan passed (gitleaks — b5314d3b59172d150587d159903642319b28d1d1..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

The qodo-code-review Go convention pack rules TC-001 and TC-002
mandate stdlib-only testing (no testify). This project uses
testify/assert and testify/require in 72% of test files (156/216),
so these rules produce false positives on idiomatic project test
code.

Add a .pr_agent.toml repo-level configuration file with
extra_instructions telling qodo's reviewer and code-suggestions
tools to skip TC-001/TC-002 enforcement and not suggest replacing
testify with stdlib assertions.

Closes #6228
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 14, 2026 16:06
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Aug 14, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 14, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 4:07 PM UTC · Completed 4:18 PM UTC

Commit: f341790 · View workflow run →

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: PR adds tooling configuration for the qodo code review bot (CI pipeline component)

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge type/chore Maintenance and housekeeping tasks component/ci CI pipelines and checks labels Aug 14, 2026
@ralphbean
ralphbean added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit 60e6677 Aug 21, 2026
41 checks passed
@ralphbean
ralphbean deleted the agent/6228-disable-stale-qodo-rules branch August 21, 2026 12:29
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 21, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 12:31 PM UTC · Completed 12:46 PM UTC

Commit: f341790 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #6230 — add qodo pr-agent config to disable stale Go test rules

This PR was a clean end-to-end success across the full agent pipeline with zero rework.

Timeline

  1. Retro agent auto-filed issue #6228 from findings on PR #6147 (Aug 14, 15:39 UTC)
  2. Triage agent ran in ~4 min, rated severity "low", confirmed no .pr_agent.toml existed, noted related issue Fullsend review agent and Qodo bot produce overlapping code-level findings, creating noise on PRs with both reviewers active #4107 (run 31815595418)
  3. Human (ralphbean) triggered /fs-code 12 min later (15:56)
  4. Code agent produced PR chore(#6228): add qodo pr-agent config to disable stale Go test rules #6230 with a single correct commit — valid TOML, correct qodo config format, well-documented PR body citing 72% testify usage across 156/216 test files (run 31816991502)
  5. Review agent approved with "Looks good to me" in ~12 min (run 31817763665)
  6. Human (ralphbean) approved without comments 7 days later (Aug 21, 12:29)
  7. PR merged immediately after human approval

What went well

Existing issue evidence (no new proposals needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ci CI pipelines and checks ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch type/chore Maintenance and housekeeping tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update qodo-code-review Go convention pack to remove stale testify rules (TC-001/TC-002)

1 participant