Skip to content

docs(#6280): remove stale mint enrollment block from getting started - #6281

Closed
rh-hemartin wants to merge 1 commit into
mainfrom
hemartin/6280-remove-mint-enrollment-docs
Closed

docs(#6280): remove stale mint enrollment block from getting started#6281
rh-hemartin wants to merge 1 commit into
mainfrom
hemartin/6280-remove-mint-enrollment-docs

Conversation

@rh-hemartin

Copy link
Copy Markdown
Member

Summary

  • Remove the "Mint enrollment" step from the getting started guide — the hosted mint is now public (mint.fullsend.sh) and requires no per-org/repo enrollment
  • Remove the corresponding entry from the guides index (docs/guides/README.md)
  • Remove the mint enrollment prerequisite from configuring-github.md

Closes #6280
Related: #3013

🤖 Generated with Claude Code

@rh-hemartin
rh-hemartin requested a review from a team as a code owner August 17, 2026 10:00
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove stale mint enrollment step from Getting Started docs

📝 Documentation 🕐 Less than 10 minutes

Grey Divider

AI Description

• Remove outdated “Mint enrollment” step now that hosted mint is public
• Update guides index to drop the removed onboarding entry
• Remove mint-enrollment prerequisite from GitHub configuration guide
Diagram

graph TD
  A["Guides index"] --> B["Getting Started"] --> C["Getting Inference"] --> D["Configuring GitHub"]
  B --> E["Org Mode"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Replace with updated “Mint” note (no enrollment required)
  • ➕ Preserves the mental model that workflows obtain tokens via a mint
  • ➕ Reduces confusion for users who saw older references to enrollment
  • ➖ Adds a step/section that may still be unnecessary for onboarding flow
2. Move mint context to a dedicated “Token mint” overview doc and link once
  • ➕ Keeps Getting Started focused while still documenting the mint concept
  • ➕ Centralizes future mint-related changes in one place
  • ➖ Requires creating/curating an additional doc page and maintaining cross-links

Recommendation: The PR’s approach (removing the obsolete enrollment requirement and associated index/prereq references) is the right default now that the hosted mint is public. Consider adding a single sentence in Getting Started or Configuring GitHub clarifying that the default hosted mint requires no enrollment, to help users reconcile older guidance they may have seen.

Files changed (3) +3 / -19

Documentation (3) +3 / -19
README.mdRemove Mint enrollment entry from guides index +0/-1

Remove Mint enrollment entry from guides index

• Drops the “Mint enrollment” link/description from the onboarding section of the guides index so the index no longer points users to a removed/obsolete step.

docs/guides/README.md

README.mdRemove Mint enrollment step and renumber onboarding steps +3/-17

Remove Mint enrollment step and renumber onboarding steps

• Deletes the Mint enrollment step and its explanatory note from the ordered getting-started sequence, then renumbers the remaining steps to start with Getting Inference.

docs/guides/getting-started/README.md

configuring-github.mdRemove mint-enrollment prerequisite from GitHub configuration guide +0/-1

Remove mint-enrollment prerequisite from GitHub configuration guide

• Eliminates the prerequisite stating the org/repo must be enrolled in a token mint, aligning setup requirements with the now-public hosted mint.

docs/guides/getting-started/configuring-github.md

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 17, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:01 AM UTC · Completed 10:14 AM UTC

Commit: 5b1bdc7 · View workflow run →

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

Site preview

Preview: https://13b86c1f-site.fullsend-ai.workers.dev

Commit: 637e8fb990da84c1cd0c75281f65067f30d19ee0

@qodo-code-review

qodo-code-review Bot commented Aug 17, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Unenroll step now ambiguous ✓ Resolved 🐞 Bug ≡ Correctness
Description
After removing mint enrollment from the Getting Started flow, the per-repo uninstall instructions
still tell users to contact the team to unenroll from the hosted mint, without clarifying this only
applies to legacy/tight-mode setups. This conflicts with the public-mint documentation that states
mint enroll is not required, and will mislead users following the updated setup path into
unnecessary support requests.
Code

docs/guides/getting-started/README.md[R10-12]

+1. [Getting Inference](getting-inference.md)
+2. [Configuring GitHub](configuring-github.md)
+3. [Organization Mode](org-mode.md)
Relevance

●●● Strong

Accepted precedent clarifies public-mint enrollment semantics; this finding similarly prevents
misleading legacy teardown guidance.

PR-#2773

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The updated Getting Started page no longer includes any mint-enrollment step, but the per-repo
uninstall guide still assumes repos must be unenrolled from the hosted mint. Meanwhile, the mint
administration guide explicitly states that in public mint mode mint enroll is not required,
implying unenrollment should not be a universal teardown requirement for repos installed via the new
flow.

docs/guides/getting-started/README.md[5-12]
docs/guides/getting-started/operations.md[66-82]
docs/guides/infrastructure/mint-administration.md[114-117]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The Getting Started flow no longer includes mint enrollment, but `docs/guides/getting-started/operations.md` still instructs per-repo uninstallers to “contact the fullsend team to unenroll the repo from the hosted mint” as a generic step. In public-mint mode, enrollment is not required, so this teardown guidance needs to be conditional/clarified (e.g., only for legacy/tight mints or previously-enrolled repos).

### Issue Context
`docs/guides/infrastructure/mint-administration.md` explicitly documents public mint mode and states that `mint enroll` is not required, which conflicts with unconditional unenrollment language in the per-repo uninstall guide.

### Fix Focus Areas
- docs/guides/getting-started/operations.md[66-82]
- docs/guides/getting-started/README.md[5-12]
- docs/guides/infrastructure/mint-administration.md[114-117]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context
✅ Compliance rules (platform): 55 rules

Grey Divider

Tip of the day
💡 Did you know, you can route each action level your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread docs/guides/getting-started/README.md
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review

Findings

Low

  • [stale-enrollment-reference] docs/guides/infrastructure/mint-administration.md:23 — States "If your organization is enrolled, you can use it directly" which implies enrollment is required. The public hosted mint now accepts any org without enrollment.
    Remediation: Update to clarify that the public hosted mint accepts any organization without enrollment.
Previous run

Review

Findings

Low

  • [stale-prerequisite] docs/guides/getting-started/repo-management.md:22 — Prerequisites section states mint enrollment must be completed before running repos install, but public mint mode (the default) requires no enrollment. Lines 91–94 of the same file already document the correct behavior.
    Remediation: Update prerequisite text to clarify enrollment is only required for private/self-hosted mint deployments. Consider a follow-up PR tracked by Add AGENTS.md guidance: update cross-referenced 'in progress' docs when implementing features #3013.

  • [incomplete-scope] docs/guides/getting-started/operations.md:72 — Uninstall section instructs users to "Contact the fullsend team to unenroll the repo from the hosted mint," which is inconsistent with public mint mode where no enrollment/unenrollment is needed.
    Remediation: Update uninstall step for GitHub repos to reflect public mint requires no unenrollment. The self-hosted path can remain. Consider addressing in a follow-up PR tracked by Add AGENTS.md guidance: update cross-referenced 'in progress' docs when implementing features #3013.


Labels: PR modifies documentation files under docs/guides/ (getting-started guide and guides index)

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge component/docs User-facing documentation labels Aug 17, 2026
…rted

The hosted mint is now public (mint.fullsend.sh) and requires no
per-org/repo enrollment. Remove the enrollment step from the getting
started guide, the guides index entry, and the configuring-github
prerequisite. Update operations.md uninstall steps and
repo-management.md prerequisites to clarify that mint enrollment
and unenrollment only apply to private/self-hosted mint deployments.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Hector Martinez <hemartin@redhat.com>
@rh-hemartin
rh-hemartin force-pushed the hemartin/6280-remove-mint-enrollment-docs branch from 5b1bdc7 to 637e8fb Compare August 17, 2026 10:32
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 17, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:33 AM UTC · Completed 10:46 AM UTC

Commit: 637e8fb · View workflow run →

@waynesun09 waynesun09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review findings (none of these lines fall within this PR's diff hunks, so posting here instead of as inline comments):


[CRITICAL] CLI mint defaults still point to legacy (non-public) Cloud Run URL, contradicting the PR's premise
internal/cli/admin.go:41

This PR's premise (per issue #6280 and the PR body) is that the hosted mint now defaults to the public https://mint.fullsend.sh and needs no enrollment. Verified on origin/main (9b5a799, this PR's actual merge base): internal/config/defaults.go:11 DefaultPerRepoMintURL and internal/cli/admin.go:41 DefaultMintURL are both still the legacy https://fullsend-mint-gljhbkcloq-uc.a.run.app. admin.go's validateMintURL (lines 200-211) only accepts .run.app/.cloudfunctions.net hosts and would reject an explicit --mint-url=https://mint.fullsend.sh. Git history confirms commit 03e09bc (#6256) fixed these constants to mint.fullsend.sh, but a later merge df491ae (#6257) silently reverted the fix back to the legacy URL/validation; a subsequent docs-only fix 34c3b3c (#6282) patched some doc references to mint.fullsend.sh without re-fixing the Go code, and is not even an ancestor of this PR's actual merge base. Curling both /health endpoints shows mint.fullsend.sh and the legacy .run.app URL are two distinct running backends (commit ed0deb8 vs 3716908), not the same service. A user following this PR's simplified fullsend github setup guide with no explicit --mint-url will hit the legacy (non-public) mint, not mint.fullsend.sh, so the enrollment prerequisite this PR removes may still be required in practice.

Failure scenario: A new user follows the updated getting-started docs (no mint enrollment step), runs fullsend github setup with default flags, and is silently routed to the legacy Cloud Run mint rather than the public mint.fullsend.sh — which may still gate access on enrollment, causing their setup to fail with no guidance since the docs no longer mention enrollment at all.

Suggestion: Before merging (or as an immediate fast-follow), verify what ALLOWED_ORGS/mode the legacy .run.app mint actually serves. If it is not in public mode, fix internal/config/defaults.go and internal/cli/admin.go to point DefaultMintURL/DefaultPerRepoMintURL at mint.fullsend.sh and restore validateMintURL's acceptance of that host before landing this docs simplification, or hold this PR and link a tracked code-level issue for the regression.


[MEDIUM] repo-management.md "Full teardown" table still requires unconditional mint unenroll
docs/guides/getting-started/repo-management.md:452

The "Full teardown" table's step 3 (GCP Admin/Mint role) still lists fullsend mint unenroll <org> as an unconditional part of the standard teardown flow. This is inconsistent with this same PR's own edit to this file's Prerequisites section (line 22) and to operations.md's uninstall section, both of which now state mint enroll/unenroll is only needed for private/self-hosted mints. Confirmed present and unchanged on PR head 637e8fb.

Failure scenario: An SRE running the documented full-teardown sequence for an org using the public hosted mint runs fullsend mint unenroll <org> unnecessarily (or hits an error/no-op), because the table gives no indication this step is conditional on using a private/self-hosted mint — contradicting the conditional language this same PR just introduced two sections earlier in the same file.

Suggestion: Qualify step 3 the same way this PR qualified the Prerequisites bullet and operations.md's uninstall copy, e.g. "GCP Admin (Mint) — fullsend mint unenroll <org> (only if using a private/self-hosted mint)".


[MEDIUM] standalone-mint.md prerequisites still list hosted-mint enrollment as required
docs/guides/infrastructure/standalone-mint.md:35

Confirmed on PR head: standalone-mint.md's Prerequisites still read "Your organization enrolled in the hosted mint (optional, for fallback proxy)" and cite the legacy .run.app URL (line 34), inconsistent with this PR's premise that the hosted mint is public and enrollment-free. Not touched by this PR.

Failure scenario: An operator setting up a standalone mint with fallback-proxy support reads this prerequisite, assumes they must arrange enrollment with the fullsend team (an internal-Slack process this PR just removed from the getting-started docs as obsolete), and either blocks on an unnecessary step or contacts the team for a non-existent process.

Suggestion: Update in the same pass (or a fast-follow) to reflect that enrollment isn't required for the public hosted mint, consistent with the language change made elsewhere in this PR.


Note: a similar finding for docs/guides/infrastructure/mint-administration.md:23 (hosted-mint access still framed as enrollment-gated) is already tracked by an existing review comment on this PR, so it's omitted here to avoid duplication.

@rh-hemartin

Copy link
Copy Markdown
Member Author

Closing this in favor of #6290

@rh-hemartin
rh-hemartin deleted the hemartin/6280-remove-mint-enrollment-docs branch August 17, 2026 13:38
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 17, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 1:40 PM UTC · Completed 1:56 PM UTC

Commit: 637e8fb · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #6281 — docs: remove stale mint enrollment block

Timeline

  1. 09:57 UTC — Issue #6280 created to remove obsolete mint enrollment docs (hosted mint is now public at mint.fullsend.sh).
  2. 09:58 UTC — Triage agent (run 32017804049) labeled ready-to-code.
  3. 09:59 UTC — Human author rh-hemartin opened PR #6281 — docs-only change (5 files, +9/−26) removing enrollment references.
  4. 10:01–10:14 UTC — Review agent run 1: found 2 low-severity stale-doc findings (repo-management.md:22, operations.md:72), approved. The intent-coherence sub-agent initially flagged these at high severity as "incomplete scope," but the challenger downgraded them to low reasoning they were outside the PR's authorized scope.
  5. 10:33–10:46 UTC — Review agent run 2: found 1 low-severity stale reference (mint-administration.md:23), approved.
  6. 12:14 UTC — Human reviewer waynesun09 posted a substantive review with a critical finding: DefaultMintURL and DefaultPerRepoMintURL in internal/config/defaults.go and internal/cli/admin.go still pointed to the legacy Cloud Run URL, not mint.fullsend.sh. A prior code fix (PR feat(#6256): default hosted mint URL to mint.fullsend.sh #6261) had been silently reverted by the merge of PR fix: remove credential mode model, separate mint mode from inference requirements #6257. Additionally, validateMintURL() would actively reject mint.fullsend.sh. The docs simplification would mislead users into hitting the legacy mint. waynesun09 also flagged stale references in repo-management.md:452 (full teardown table) and standalone-mint.md:35 that the agent missed.
  7. 13:38 UTC — Author closed PR docs(#6280): remove stale mint enrollment block from getting started #6281 in favor of PR #6290, which fixes both the Go code defaults and the docs.

Key gap

The review agent approved a docs-only PR whose core behavioral claim ("enrollment is no longer needed") was contradicted by the actual code. The agent's docs-currency dimension checks code→docs staleness but not docs→code accuracy. The correctness sub-agent was dispatched (with "small" scope) but did not verify the PR's behavioral claims against the Go source files. The human reviewer traced git history, discovered the silent revert, verified both mint URLs were live but serving different backends, and identified that validateMintURL() would reject mint.fullsend.sh — cross-layer analysis the agent did not perform.

Evidence for existing issues (skipped as proposals)

  • agents#265 (cross-reference verified facts to detect misleading docs narratives): This retro is a concrete instance — the docs narrative that enrollment was removed was misleading because the code didn't support it.
  • fullsend#1542 (validate documented CLI workflows against code behavior): The PR documented a workflow change (no enrollment needed) that the CLI code didn't implement.
  • agents#112 (detect when previously-fixed findings regress after rebase): PR fix: remove credential mode model, separate mint mode from inference requirements #6257 silently reverted PR feat(#6256): default hosted mint URL to mint.fullsend.sh #6261's mint URL fix — exactly the regression-after-merge scenario this issue targets.
  • fullsend#5297 (cross-validate docs examples against source files): The docs referenced mint.fullsend.sh but the code default was still the legacy URL.
  • agents#811 (scan sibling files when stale-doc drift detected): The agent found staleness in some files but missed standalone-mint.md:35 and repo-management.md:452.

Autonomy assessment

The review agent's two approvals were incorrect — the human review caught a critical issue the agent missed entirely. For docs-only PRs that change behavioral guidance about system features, the current review dimensions are insufficient to grant autonomous merge authority. The cross-layer verification capabilities proposed in existing issues (agents#265, fullsend#1542) would need to land before reconsidering autonomy for this class of change.

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/docs User-facing documentation ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: remove stale mint enrollment block from getting started guide

3 participants