docs(#6280): remove stale mint enrollment block from getting started - #6281
docs(#6280): remove stale mint enrollment block from getting started#6281rh-hemartin wants to merge 1 commit into
Conversation
PR Summary by QodoRemove stale mint enrollment step from Getting Started docs
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
|
🤖 Finished Review · ✅ Success · Started 10:01 AM UTC · Completed 10:14 AM UTC Commit: |
Site previewPreview: https://13b86c1f-site.fullsend-ai.workers.dev Commit: |
Code Review by Qodo
1.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsLow
Previous runReviewFindingsLow
Labels: PR modifies documentation files under docs/guides/ (getting-started guide and guides index) |
…rted The hosted mint is now public (mint.fullsend.sh) and requires no per-org/repo enrollment. Remove the enrollment step from the getting started guide, the guides index entry, and the configuring-github prerequisite. Update operations.md uninstall steps and repo-management.md prerequisites to clarify that mint enrollment and unenrollment only apply to private/self-hosted mint deployments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Hector Martinez <hemartin@redhat.com>
5b1bdc7 to
637e8fb
Compare
|
🤖 Finished Review · ✅ Success · Started 10:33 AM UTC · Completed 10:46 AM UTC Commit: |
waynesun09
left a comment
There was a problem hiding this comment.
Review findings (none of these lines fall within this PR's diff hunks, so posting here instead of as inline comments):
[CRITICAL] CLI mint defaults still point to legacy (non-public) Cloud Run URL, contradicting the PR's premise
internal/cli/admin.go:41
This PR's premise (per issue #6280 and the PR body) is that the hosted mint now defaults to the public https://mint.fullsend.sh and needs no enrollment. Verified on origin/main (9b5a799, this PR's actual merge base): internal/config/defaults.go:11 DefaultPerRepoMintURL and internal/cli/admin.go:41 DefaultMintURL are both still the legacy https://fullsend-mint-gljhbkcloq-uc.a.run.app. admin.go's validateMintURL (lines 200-211) only accepts .run.app/.cloudfunctions.net hosts and would reject an explicit --mint-url=https://mint.fullsend.sh. Git history confirms commit 03e09bc (#6256) fixed these constants to mint.fullsend.sh, but a later merge df491ae (#6257) silently reverted the fix back to the legacy URL/validation; a subsequent docs-only fix 34c3b3c (#6282) patched some doc references to mint.fullsend.sh without re-fixing the Go code, and is not even an ancestor of this PR's actual merge base. Curling both /health endpoints shows mint.fullsend.sh and the legacy .run.app URL are two distinct running backends (commit ed0deb8 vs 3716908), not the same service. A user following this PR's simplified fullsend github setup guide with no explicit --mint-url will hit the legacy (non-public) mint, not mint.fullsend.sh, so the enrollment prerequisite this PR removes may still be required in practice.
Failure scenario: A new user follows the updated getting-started docs (no mint enrollment step), runs fullsend github setup with default flags, and is silently routed to the legacy Cloud Run mint rather than the public mint.fullsend.sh — which may still gate access on enrollment, causing their setup to fail with no guidance since the docs no longer mention enrollment at all.
Suggestion: Before merging (or as an immediate fast-follow), verify what ALLOWED_ORGS/mode the legacy .run.app mint actually serves. If it is not in public mode, fix internal/config/defaults.go and internal/cli/admin.go to point DefaultMintURL/DefaultPerRepoMintURL at mint.fullsend.sh and restore validateMintURL's acceptance of that host before landing this docs simplification, or hold this PR and link a tracked code-level issue for the regression.
[MEDIUM] repo-management.md "Full teardown" table still requires unconditional mint unenroll
docs/guides/getting-started/repo-management.md:452
The "Full teardown" table's step 3 (GCP Admin/Mint role) still lists fullsend mint unenroll <org> as an unconditional part of the standard teardown flow. This is inconsistent with this same PR's own edit to this file's Prerequisites section (line 22) and to operations.md's uninstall section, both of which now state mint enroll/unenroll is only needed for private/self-hosted mints. Confirmed present and unchanged on PR head 637e8fb.
Failure scenario: An SRE running the documented full-teardown sequence for an org using the public hosted mint runs fullsend mint unenroll <org> unnecessarily (or hits an error/no-op), because the table gives no indication this step is conditional on using a private/self-hosted mint — contradicting the conditional language this same PR just introduced two sections earlier in the same file.
Suggestion: Qualify step 3 the same way this PR qualified the Prerequisites bullet and operations.md's uninstall copy, e.g. "GCP Admin (Mint) — fullsend mint unenroll <org> (only if using a private/self-hosted mint)".
[MEDIUM] standalone-mint.md prerequisites still list hosted-mint enrollment as required
docs/guides/infrastructure/standalone-mint.md:35
Confirmed on PR head: standalone-mint.md's Prerequisites still read "Your organization enrolled in the hosted mint (optional, for fallback proxy)" and cite the legacy .run.app URL (line 34), inconsistent with this PR's premise that the hosted mint is public and enrollment-free. Not touched by this PR.
Failure scenario: An operator setting up a standalone mint with fallback-proxy support reads this prerequisite, assumes they must arrange enrollment with the fullsend team (an internal-Slack process this PR just removed from the getting-started docs as obsolete), and either blocks on an unnecessary step or contacts the team for a non-existent process.
Suggestion: Update in the same pass (or a fast-follow) to reflect that enrollment isn't required for the public hosted mint, consistent with the language change made elsewhere in this PR.
Note: a similar finding for docs/guides/infrastructure/mint-administration.md:23 (hosted-mint access still framed as enrollment-gated) is already tracked by an existing review comment on this PR, so it's omitted here to avoid duplication.
|
Closing this in favor of #6290 |
|
🤖 Finished Retro · ✅ Success · Started 1:40 PM UTC · Completed 1:56 PM UTC Commit: |
Retro: PR #6281 — docs: remove stale mint enrollment blockTimeline
Key gapThe review agent approved a docs-only PR whose core behavioral claim ("enrollment is no longer needed") was contradicted by the actual code. The agent's Evidence for existing issues (skipped as proposals)
Autonomy assessmentThe review agent's two approvals were incorrect — the human review caught a critical issue the agent missed entirely. For docs-only PRs that change behavioral guidance about system features, the current review dimensions are insufficient to grant autonomous merge authority. The cross-layer verification capabilities proposed in existing issues (agents#265, fullsend#1542) would need to land before reconsidering autonomy for this class of change. Proposals filed
|
Summary
mint.fullsend.sh) and requires no per-org/repo enrollmentdocs/guides/README.md)configuring-github.mdCloses #6280
Related: #3013
🤖 Generated with Claude Code