ci: add dispatch workflow to trigger scaffold sync - #6379
Conversation
PR Summary by QodoTrigger scaffold sync and document per-repo migration
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Site previewPreview: https://681e6758-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 1:39 PM UTC · Completed 1:57 PM UTC Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review by Qodo
1.
|
ReviewFindingsMedium
Low
Previous runReviewFindingsMedium
Previous run (2)ReviewFindingsMedium
Previous run (3)ReviewFindingsMedium
Low
Previous run (4)ReviewFindingsMedium
Low
Previous run (5)ReviewFindingsMedium
Previous run (6)ReviewFindingsMedium
Previous run (7)ReviewFindingsMedium
Low
Labels: PR adds a CI workflow file under .github/workflows/ Previous run (8)ReviewFindingsHigh
Medium
Next steps:
Previous run (9)ReviewFindingsMedium
Low
Previous run (10)ReviewFindingsHigh
Medium
Low
Next steps:
|
19c8e5c to
d27b520
Compare
|
🤖 Finished Review · ✅ Success · Started 2:19 PM UTC · Completed 2:34 PM UTC Commit: |
Superseded by updated review
d27b520 to
b24373f
Compare
|
🤖 Finished Review · ✅ Success · Started 2:40 PM UTC · Completed 2:55 PM UTC Commit: |
b24373f to
2d3b5a9
Compare
|
🤖 Finished Review · ✅ Success · Started 3:01 PM UTC · Completed 3:14 PM UTC Commit: |
Superseded by updated review
2d3b5a9 to
b5872f8
Compare
|
🤖 Finished Review · ✅ Success · Started 3:21 PM UTC · Completed 3:33 PM UTC Commit: |
waynesun09
left a comment
There was a problem hiding this comment.
Review-squad pass at head b5872f81 — 3 agents (two Claude lenses: diff correctness and external-claim verification; plus an independent Grok pass). Review-only, 3 MEDIUM findings inline.
Everything raised earlier is confirmed fixed at this head (timeout-minutes, repositories: token scoping, concurrency block, cancel-in-progress removal), and the migration-plan doc findings are moot now that the file has left the PR.
Verified clean, for the record:
event_type=fullsend-updatedexactly matcheson.repository_dispatch.typesin.fullsend:sync-scaffold.yml, and #174 is merged to.fullsendmain — so the receiver does exist on the default branch, asrepository_dispatchrequires.- No sync loop:
fullsend-ai/fullsendis not in.fullsend:repos.yaml(onlyexperiments,metrics,agents), so no scaffold commit can re-fire this dispatcher. Worth stating explicitly since that invariant lives in another repo with nothing here recording the dependency. - Action pin
bcd2ba4is genuinely thev3tag target, and the leading dot in.fullsendneeds no quoting at any layer (YAML scalar, action parser, Octokit path encoding). -f "client_payload[sha]=..."does produce correctly nested JSON (checked empirically withGH_DEBUG=api), andpermissions: {}is correct —GITHUB_TOKENis unused here.
LOW, not posted inline: client_payload.sha is sent but never read — sync-scaffold.yml clones --depth 1 with no --branch and builds default-branch HEAD, despite its own comment claiming it builds the triggering commit; ${{ github.sha }} is interpolated straight into the run: block instead of going through env: (not injectable, but it's the pattern actionlint/zizmor flag); and there's no workflow_dispatch: trigger, so the wiring can't be exercised without a push to main.
b5872f8 to
64c371d
Compare
|
🤖 Finished Review · ✅ Success · Started 4:10 PM UTC · Completed 4:20 PM UTC Commit: |
64c371d to
9753733
Compare
|
🤖 Finished Review · ✅ Success · Started 4:49 PM UTC · Completed 5:04 PM UTC Commit: |
9753733 to
bea137e
Compare
|
🤖 Finished Review · ✅ Success · Started 5:12 PM UTC · Completed 5:22 PM UTC Commit: |
bea137e to
de333b5
Compare
|
🤖 Finished Review · ✅ Success · Started 5:30 PM UTC · Completed 5:42 PM UTC Commit: |
waynesun09
left a comment
There was a problem hiding this comment.
Automated review sweep — 2 additional findings not covered by prior review rounds.
de333b5 to
27044f5
Compare
|
🤖 Finished Review · ✅ Success · Started 5:46 PM UTC · Completed 5:58 PM UTC Commit: |
waynesun09
left a comment
There was a problem hiding this comment.
Automated review sweep at head 27044f50 — 3 MEDIUM findings not covered by prior review rounds. Review-only; no approval or change request implied.
Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
27044f5 to
437e488
Compare
|
🤖 Finished Review · ✅ Success · Started 11:10 PM UTC · Completed 11:23 PM UTC Commit: |
Closes #6381
Summary
repository_dispatchevent tofullsend-ai/.fullsendwheneverfullsendmain is updatedsync-scaffoldworkflow (Replace renovate agent digest tracking with sync workflow .fullsend#174) to build the latestfullsendCLI and runrepos installto converge scaffold files and variables across per-repo installsfullsend-ai-syncApp (SYNC_APP_ID/SYNC_PRIVATE_KEY, already provisioned on this repo)Prerequisites
Test plan
.fullsend🤖 Generated with Claude Code