docs(#6539): one local-run flow — pi is a --runtime flag on the standard examples - #6540
Conversation
PR Summary by QodoDocs: unify local-run guide; choose pi via --runtime on standard examples
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
|
🤖 Review · Commit: |
Site previewPreview: https://cd0ffaa1-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review by Qodo
1.
|
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 7:45 PM UTC · Completed 7:59 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $6.50 |
ReviewFindingsLow
Labels: PR modifies only documentation files under docs/ Previous runReviewFindingsLow
|
|
🤖 Finished Review · ✅ Success · Started 8:03 PM UTC · Completed 8:19 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $5.26 |
|
Sounds like we need a runtime section with a page for each runtime with details about it. I think we need to keep the "running agents locally" basic and not mentioning |
|
/fs-fix-stop |
|
Fix agent disabled for this PR. Remove the |
…ard examples The guide taught pi as a 350-line parallel walkthrough (hand-rolled pi-hello harness, own config/profile/policy) written before the runtime became a per-run choice (#6526) and before the fleet repo carried the pi plumbing (agents#965/#975). Now there is one flow: the standard fleet examples, plus a "Choosing the runtime" subsection with --runtime pi on the same commands, the override precedence table (both runtimes), the verbatim output of a verified run (fullsend main @ 89bf3b8 against agents main @ 299f264 on macOS and Fedora — harness-default values print bare, overrides carry their source), Gemini-on-Vertex selection by model name, and a compact pi-notes list (build the CLI from main until a release ships pi; image 0.37+ and the exit-127 preflight symptom; review/retro single-context; FULLSEND_PI_PROVIDER and the bash allowlist; fail-closed hooks; --debug='*' and pi-debug.log). The pi platform notes fold into the existing Platform notes as one bullet per OS, and docs/runtimes.md points at the new anchor. Closes #6539 Assisted-by: Claude (code) Signed-off-by: Wayne Sun <gsun@redhat.com>
…located troubleshooting The runtimes.md callout no longer promises a fleet-free walkthrough; the image requirement is stated as 'bakes PI_VERSION' instead of an unsourced 0.37+ tag; the operational knowledge from the deleted section (sandbox env via harness host_files not --env-file, export in .env.d, the disabled-provider symptom, the silent claude fallback and where to see it) lives in a pi subheading under Troubleshooting; the container path carries the same build-from-main caveat; the Gemini example is a full command; old anchors get HTML aliases; run-dir tree notes pi-debug.log; guides index no longer claims released binaries cover pi. Assisted-by: Claude (fix), Grok (review) Signed-off-by: Wayne Sun <gsun@redhat.com>
…to the Pi page (review) Per rh-hemartin's review: the local-run guide stays basic. "Choosing the runtime" is now one command plus links; the verified pi output, the local requirements, platform notes and pi troubleshooting move to a new "Running it locally" section on docs/runtimes/pi.md (whose links now point at itself, not back at the guide), and the agent set → list → plan-block flow grows the existing CLI line in the per-agent section of docs/runtimes.md with generic paths. The guide gains a See also. Assisted-by: Claude Signed-off-by: Wayne Sun <ericbreeze@gmail.com>
|
@rh-hemartin — agreed, and done as of
Left for a follow-up so this PR stays a doc reshape: moving "Debugging network policies locally" (145 lines) to its own page and the status/remote flag tables into |
|
🤖 Review · Commit: |
Assisted-by: Claude Signed-off-by: Wayne Sun <ericbreeze@gmail.com>
|
🤖 Review · Commit: |
…s does not escape it Assisted-by: Claude Signed-off-by: Wayne Sun <ericbreeze@gmail.com>
|
🤖 Review · Commit: |
…solves on the site VitePress slugs "config.yaml" as "config-yaml" while GitHub drops the dot, so every link to #per-agent-runtime-model-and-effort-in-configyaml landed at the top of the Runtimes page on the published site. The heading is now "Per-agent runtime, model and effort" (identical slug on both), with the config.yaml mention moved into the first sentence; the four links follow. Assisted-by: Claude Signed-off-by: Wayne Sun <ericbreeze@gmail.com>
44d2ab3 to
cb50b8f
Compare
|
🤖 Finished Review · ✅ Success · Started 6:03 PM UTC · Completed 6:23 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $7.07 |
|
🤖 Finished Retro · ✅ Success · Started 6:13 PM UTC · Completed 6:27 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $5.33 |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
Retro: PR #6540 — docs(#6539): one local-run flowTimeline
ObservationsCode agent: correct edits, zero output. The code agent understood the task, explored the right files, made valid edits, and verified them with lint checks — then ended without committing. The root cause is that Review agent vs. human reviewer gap. The review agent caught valid but low-impact mechanical findings (anchor placement, heading style). The human reviewer caught the higher-value structural concern: the guide's scope was wrong. The PR existed because pi content had bloated the guide, yet the initial PR still inlined pi content. The human recognized this meta-problem; the agent did not. This gap aligns with existing issue #3639 (intent-coherence sub-agent should evaluate approach proportionality) — this PR provides concrete evidence for that proposal. Cancelled review dispatches. Five review dispatches were cancelled on Aug 25 due to rapid human pushes. Already tracked by #4069 and #4960. Total agent cost: ~$15.61 (triage $0.79 + code $3.06 + review $11.76). The code agent cost was entirely wasted. The review cost was reasonable for the diff scope but both reviews were superseded by the human-requested reshape. Agents repoDiscovered from triage run logs: Proposals filed
|
Summary
Replaces the 350-line pi-specific walkthrough in
docs/guides/user/running-agents-locally.mdwith a single local-run flow that stays runtime-agnostic: the existing fleet examples plus a short "Choosing the runtime" redirect (one--runtime picommand and links to the Runtimes section). The pi content that a local run actually needs moves to a new Running it locally section ondocs/runtimes/pi.md, and the per-agentagent set→agent list→ plan-block flow lands in the per-agent section ofdocs/runtimes.md(from #6583). Shape agreed with @rh-hemartin's review comment. 890 → 562 lines; no code changes.The example output is verbatim from a verified run of fullsend
main@89bf3b8against fullsend-ai/agentsmain@299f264(macOS Apple Silicon and Fedora): harness-defaultModel:/Effort:print bare, overridden values carry(from …),metrics.jsonshowsruntime_sourceseparately fromoverride_source.review/retrowere re-confirmed schema-valid under--runtime pi(single-context, stated as such). The doc deliberately shows Gemini selection syntax without a success transcript (known model-behaviour items are tracked in #6527/#6535).Note: the code agent's run for #6539 ended with "no changed files", so this PR was authored directly by the human takeover session.
Rebase 2026-08-25 (after #6574 / #6583) and reshape per review
d3bcc36(answering @rh-hemartin): the guide keeps exactly one pi command; everything else pi moved to the Pi page. Follow-up (not in this PR): move "Debugging network policies locally" to its own page and the status/remote flag tables intodocs/cli/run.md.docs/runtimes.mdis no longer touched: the callout this PR rewrote moved todocs/runtimes/pi.mdin docs: split runtimes.md into a user page and an implementer page #6574, so that page's two links now target#choosing-the-runtime; the pi-notes cross-link goes to the Pi page and the security feature matrix inruntime-implementation.md.v0.37.0 is the first release that carries the pi runtime (
internal/runtime/pi*.gois in the tag;fullsend-runner:0.37.0published), so the build-from-mainbullet and the guides-index caveat are gone.Per-agent settings from feat(#6581): per-agent runtime, model and effort on agents: entries #6583: the override table gains a "Per-agent config" column and the precedence line reads flag > env > the agent's
agents:entry > repo-wide; a "Make it stick per agent" flow (set → list → plan block, early validation errors) is taken from the local verification matrix on feat(#6581): per-agent runtime, model and effort on agents: entries #6583 — the fleet clone the guide already uses is a per-repo-style config, sofullsend agent set … --fullsend-dir /tmp/fullsend-agents/works on the guide's own example.Site preview check (playwright, 2026-08-25)
Verified on the PR preview: guide stub + alias anchors + See also, the Pi page's new section and troubleshooting, the runtimes per-agent list — all internal links 200, same-page anchors resolve, no console errors. Two things it caught, fixed in follow-up commits: a line-wrapped
<config path>code span rendered as<config path>, and the per-agent heading's anchor — VitePress slugsconfig.yamlasconfig-yaml, GitHub asconfigyaml— so the four links to it (three from #6583) landed at the page top on the site; the heading is now "Per-agent runtime, model and effort" (same slug on both). The same GitHub-vs-VitePress divergence affects ~20 older links (ADRs, landscape, architecture) — out of scope here, noted for the follow-up.Review rounds
docs/runtimes.mdcallout still promised a "no fleet repo required" walkthrough (rewritten); MEDIUMs all applied: image requirement now referenced as v0.37.0+ (was an unsourced tag mix-up), the deleted section's operational knowledge relocated into a pi runtime Troubleshooting subheading (sandbox env via harnesshost_filesnot--env-fileper ADR 0055,exportneeded in.env.dfiles — re-verified againstrun.go's plain.sourcing loop — the disabled-provider symptom, the silent-Claude fallback and where the plan block shows it), the container path carries the same build-from-main caveat, HTML alias anchors keep the three old permalinks working, the Gemini example is a full command, run-dir tree notespi-debug.log, guides index no longer claims released binaries cover pi.withSourcebare-vs-annotated printing,FULLSEND_PI_PROVIDERdefault,FULLSEND_PI_BASH_ALLOWLIST=enforce, the#choosing-the-runtimeanchor.Related Issue
Closes #6539
Changes
--runtime picommand, links to Agent runtimes and Pi › Running it locally, alias anchors for the three old permalinks; plus a See also at the end of the guidedocs/runtimes/pi.md: new "Running it locally" section (prerequisite pointer, verified plan block, model selection, v0.37.0+ CLI/image, platforms, single-contextreview/retro, knobs, hooks, debugging) and five troubleshooting entries moved from the guidedocs/runtimes.md: the per-agent section's CLI line grows into the set → list → plan-block flow with generic pathsdocs/runtimes/pi.md) two local-run links to the new anchorTesting
make lintequivalents on changed files: docs-link lint, lychee, markdown checks via pre-commit — cleanChecklist
!for breaking changes)