Skip to content

docs(#6759): add normative-spec doc-update trigger to AGENTS.md - #6761

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/6759-add-normative-spec-trigger
Open

docs(#6759): add normative-spec doc-update trigger to AGENTS.md#6761
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/6759-add-normative-spec-trigger

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Adds a missing doc-update trigger to AGENTS.md so code agents automatically update normative event documentation when modifying event_payload or normalized-event structures. Also adds the normative event specification to the topic-specific guidance table.

Related Issue

Closes #6759

Changes

  • Added a doc-update trigger bullet in the "How to work in this repo" section instructing agents to update docs/normative/normalized-event/v1/README.md (projection table) and docs/contributing/harness-fields.md (resolution description) when modifying buildEventPayload in internal/harnessdispatch/project.go or normalized-event structures in internal/normevent/
  • Added docs/normative/normalized-event/v1/README.md to the topic-specific guidance table with trigger conditions for event_payload, normevent, and adapter changes

Testing

  • Verified no trailing whitespace and file ends with newline
  • lychee link check passed (25 OK, 0 errors) — all markdown links valid
  • gitlint passed on commit message

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Commits are signed off (DCO) — human and human-directed agent sessions only
  • I wrote this contribution myself and can explain all changes in it

Closes #6759

Post-script verification

  • Branch is not main/master (agent/6759-add-normative-spec-trigger)
  • Secret scan passed (gitleaks — dc0f8e15488fc816f9464c63e644e17de549edd1..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

Add a doc-update trigger for event_payload and normalized-event
structure changes, following the existing pattern of lines 20-23
in AGENTS.md. When agents modify buildEventPayload in
internal/harnessdispatch/project.go or normalized-event
structures in internal/normevent/, they are now instructed to
update the projection table in
docs/normative/normalized-event/v1/README.md and the resolution
description in docs/contributing/harness-fields.md.

Also add the normative event specification to the topic-specific
guidance table so agents read the full spec when modifying
event_payload, normevent structures, or adapters.

Note: pre-commit could not run in sandbox (HTTP 403 fetching
remote hook repos). Hooks were verified manually: no trailing
whitespace, file ends with newline, lychee link check passed
(25 OK, 0 errors).

Closes #6759
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 29, 2026 18:40
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Aug 29, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 29, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:42 PM UTC · Completed 6:53 PM UTC

Commit: deb3fa1 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.47

@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Aug 29, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Minimal 2-line docs-only addition to AGENTS.md by a known bot. Score elevated from 1 to 2 because AGENTS.md is a protected path with high recent churn (29 commits/30d) and many distinct authors (9/90d), indicating the file is actively contested. The actual risk of this specific additive change is low given its tiny scope and docs-only nature.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] AGENTS.md — This PR modifies AGENTS.md, which is a protected governance file. The change is well-motivated (linked to Add normative-spec doc-update trigger to AGENTS.md for event_payload changes #6759, which documents a concrete gap in agent doc-update triggers) and the additions follow established patterns. However, human approval is always required for protected-path changes, regardless of context.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Agent PR ready for human review requires-manual-review Review requires human judgment risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add normative-spec doc-update trigger to AGENTS.md for event_payload changes

0 participants