Skip to content

docs: remove internal-only e2e role from the user-facing role matrix - #6771

Merged
rh-hemartin merged 1 commit into
mainfrom
docs/6563-remove-e2e-role-from-matrix
Sep 1, 2026
Merged

docs: remove internal-only e2e role from the user-facing role matrix#6771
rh-hemartin merged 1 commit into
mainfrom
docs/6563-remove-e2e-role-from-matrix

Conversation

@waynesun09

Copy link
Copy Markdown
Member

What

Removes the e2e row and its permissions note from the Role Permissions Matrix in docs/guides/infrastructure/infrastructure-reference.md (the row was added in #6652).

Why

e2e is an internal role used only to drive fullsend's own end-to-end / behaviour test tooling against disposable test orgs. It is not a role users select for their agents. Listing it in the user-facing matrix alongside coder/review/triage/etc. implies it is a selectable option, which is exactly the role-selection confusion #6563 is about. The matrix should show only roles intended for user/agent configuration.

This is docs-only — no behaviour change. The role continues to exist and function for internal test tooling.

Relates to #6563 (BYOA role selection).

🤖 Generated with Claude Code

The e2e role drives fullsend's own end-to-end/behaviour test tooling; it
is not a role users configure for their agents. Listing it in the Role
Permissions Matrix (added in #6652) implies it is selectable alongside
coder/review/etc. Remove the e2e row and its permissions note so the
matrix reflects only roles intended for user/agent configuration.

Relates to #6563 (BYOA role selection).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014X4fMw1vDSNwXYVh4DN1FX
Signed-off-by: Wayne Sun <gsun@redhat.com>
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove internal e2e role from the user-facing permissions matrix

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Removes the internal-only e2e role from the user-facing permissions matrix.
• Removes the related note describing permissions irrelevant to configurable agent roles.
• Prevents readers from mistaking e2e for a selectable agent role.
High-Level Assessment

Removing the internal role from the user-facing matrix is the clearest approach because it preserves internal test behavior while eliminating role-selection ambiguity. Adding an internal-only annotation was considered but would retain irrelevant implementation detail in user documentation.

Files changed (1) +0 / -3

Documentation (1) +0 / -3
infrastructure-reference.mdRemove internal e2e role from permissions matrix +0/-3

Remove internal e2e role from permissions matrix

• Removes the 'e2e' role row and its additional permissions note from the Role Permissions Matrix. The matrix now lists only roles intended for user and agent configuration.

docs/guides/infrastructure/infrastructure-reference.md

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://012f6da0-site.fullsend-ai.workers.dev

Commit: 025ad23a861b7bada3c26b029ce8f7bd6ca56933

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 29, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:23 PM UTC · Completed 10:35 PM UTC

Commit: 025ad23 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.12

@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Aug 29, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: low (1/5)

Details

Docs-only change: removes the internal e2e role row (3 lines) from the user-facing role permissions matrix in infrastructure-reference.md. Single file, no code, no protected paths, no security sensitivity. Aligns with linked issue #6563 about confusing internal roles. Trivially reversible.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [stale-doc-reference] docs/guides/user/bring-your-own-agent.md:338 — The BYO agent guide still lists e2e as a valid value in the roles field: "Valid values: fullsend, triage, coder, review, fix, retro, prioritize, e2e". This is a user-facing doc and contradicts the PR's goal of removing e2e from user-facing documentation.
    Remediation: Remove e2e from the valid-values list, or add a note that it is internal-only.

Low

  • [stale-doc-reference] docs/cli/mint.md:108 — The --roles flag example in the CLI reference still includes e2e in its comma-separated list: --roles=fullsend,triage,coder,review,retro,prioritize,e2e. While this is an operator-facing doc, consistency with the PR's intent would suggest updating it too.
    Remediation: Remove ,e2e from the example value, or keep it intentionally if this doc targets internal operators.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@rh-hemartin
rh-hemartin added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 8835810 Sep 1, 2026
55 checks passed
@rh-hemartin
rh-hemartin deleted the docs/6563-remove-e2e-role-from-matrix branch September 1, 2026 09:35
@fullsend-ai-retro

fullsend-ai-retro Bot commented Sep 1, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 9:37 AM UTC · Completed 9:45 AM UTC

Commit: 025ad23 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.17

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #6771 — docs: remove internal-only e2e role from the user-facing role matrix

Timeline

  1. 2026-08-24: Retro agent filed issue #6563 about opaque 403 errors for unregistered BYO agent roles.
  2. 2026-08-29 22:21 UTC: Wayne Sun opened PR #6771, a docs-only change removing 3 lines from infrastructure-reference.md to eliminate the e2e row from the user-facing role permissions matrix. Co-authored with Claude Opus 4.8 via a local Claude Code session.
  3. 2026-08-29 22:22–22:35 UTC: Review agent ran (workflow run 33278403494) — Opus, high effort, $3.12. Assessed risk as low (1/5). Requested changes with two findings: (a) bring-your-own-agent.md:338 still lists e2e as a valid role value (medium), (b) mint.md:108 CLI example still includes e2e (low).
  4. 2026-08-31 06:35 UTC: Human reviewer rh-hemartin approved without comments.
  5. 2026-09-01 09:35 UTC: PR merged without addressing the review agent's findings.

What went well

The review agent's cross-file stale-reference detection was excellent. It correctly identified that removing e2e from one docs file while leaving it in two other user-facing docs creates inconsistency. This is the kind of mechanical consistency check where automated review consistently outperforms human review. The agent's medium-severity finding about bring-your-own-agent.md is particularly strong — that file is explicitly user-facing and listing e2e as a valid role value directly contradicts the PR's stated goal of preventing users from thinking e2e is a selectable role.

Evidence for existing issues

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/low PR risk: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants