docs(#6781): promote forge-abstraction to explicit AGENTS.md bullet - #6783
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#6781): promote forge-abstraction to explicit AGENTS.md bullet#6783fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a top-level bullet point in the "How to work in this repo" section for the forge-abstraction rule, placed after the Go coverage gate and before the secrets bullet. The rule was previously discoverable only via the topic-guidance table, which required agents to recognize that setting repository variables is a forge operation — a connection the code agent on PR #6779 failed to make. Promoting it to an inline bullet mirrors the pattern used for other critical rules (DCO, coverage gate, CLI docs) and makes the architectural invariant harder to miss for both code and review agents. Closes #6781
|
🤖 Finished Review · ✅ Success · Started 6:30 PM UTC · Completed 6:41 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.85 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: low (1/5) DetailsDocs-only 1-line addition to AGENTS.md by a bot author with no security-sensitive files, no CI changes, and no dependency changes. The change is trivially small and easily revertible. |
ReviewFindingsMedium
|
fullsend-ai-review
Bot
added
the
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a top-level bullet point for the forge-abstraction rule in the "How to work in this repo" section of
AGENTS.md. The rule was previously listed only in the topic-guidance table, which required agents to infer that operations like setting repository variables are forge operations. This promotion mirrors the pattern used for other critical rules (DCO, coverage gate, CLI docs) and makes the architectural invariant — all forge operations must go throughforge.Client— harder to miss.Changes
docs/contributing/forge-abstraction.mdfor full detailsTesting
lycheelink checker passes onAGENTS.mdforge.Clientandforge-abstraction.mdare present inAGENTS.mdgitlintpasses on commit messageChecklist
!for breaking changes)Closes #6781
Post-script verification
agent/6781-promote-forge-abstraction-bullet)e90aca92240c9d478677c6c5cc70e0a9b0edb95a..HEAD)