fix(#6824): fall back to main when agents repo version tag is missing - #6826
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#6824): fall back to main when agents repo version tag is missing#6826fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
When a release build resolves agents from fullsend-ai/agents using a version-tagged ref (e.g. tags/v0.38.0) and that tag does not exist, fetchPinnedAgentsRepoFile now retries with heads/main instead of failing immediately. This prevents auto-triggered dispatches from failing with a 404 when the agents repo has not yet been tagged for the running CLI version. The fallback logs a warning so the missing tag is visible in run output. Dev builds (which already use heads/main) are unaffected. Note: pre-commit could not run in this sandbox (network restrictions blocked hook repo fetching). gofmt and go vet were run directly and passed. Closes #6824
|
🤖 Finished Review · ✅ Success · Started 8:40 PM UTC · Completed 8:55 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.38 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsSmall, well-scoped bug fix with strong test coverage (50% test file ratio) from a known bot author. The changed files are hot (86+ commits in 30 days, 17 distinct authors), but the change is minimal and tightly scoped to the linked issue. Composite rounds to 2 (moderate). |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a release build's version tag (e.g.
tags/v0.38.0) doesn't exist in thefullsend-ai/agentsrepo, the CLI now falls back to resolving fromheads/maininstead of failing with a 404. This fixes auto-triggered fix dispatches that fail immediately when the agents repo hasn't been tagged for the running CLI version.Related Issue
Fixes #6824
Changes
fetchPinnedAgentsRepoFile()ininternal/cli/run.goto retry withheads/mainwhen a version-tagged ref returns an errortags/refs — dev builds (which already useheads/main) are unaffectedheads/mainalso fails, the original failure behavior is preservedTesting
TestTryAgentsRepoFallback_ReleaseBuild_MissingTagFallsBackToMain— verifies successful fallback to main when version tag is missingTestTryAgentsRepoFallback_ReleaseBuild_MissingTagAndMainFails— verifies graceful failure when both tag and main are unavailableTestTryAgentsRepoFallback_DevBuild_NoFallback— verifies dev builds don't exercise the tag-fallback pathTestTryAgentsRepoFallback_*andTestResolveAgentsRef_*tests passfetchPinnedAgentsRepoFile, 100% onresolveAgentsRefgofmtandgo vetpassCloses #6824
Post-script verification
agent/6824-fallback-agents-ref)2a29f774dbf5707909c4265d10b2b4b324c8a344..HEAD)