Skip to content

feat(#6): add GET /foo endpoint returning {"result": "bar"} #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −0
Open

feat(#6): add GET /foo endpoint returning {"result": "bar"} #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ac9ea
feat(#6): add GET /foo endpoint returning {"result": "bar"}
Jun 5, 2026
5350921
docs: add GET /foo endpoint to README endpoints table
Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ A simple Flask REST API for managing a todo list.
| POST | `/items` | Create an item (`{"name": "..."}`) |
| PATCH | `/items/:id` | Update an item (`{"done": true}`) |
| DELETE | `/items/:id` | Delete an item |
| GET | `/foo` | Returns static response `{"result": "bar"}` |

## Development

Expand Down
5 changes: 5 additions & 0 deletions app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ def delete_item(item_id):
return "", 204


@app.route("/foo")

@fullsend-ai-review fullsend-ai-review Bot Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] pattern-inconsistency

Route decorator omits explicit methods=["GET"]. The codebase is inconsistent: /health also omits it while /items specifies it. Consider aligning for consistency.

@fullsend-ai-review fullsend-ai-review Bot Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] design-smell

The /foo endpoint is architecturally distinct from the todo-list domain but explicitly authorized by issue #6. Consider adding a code comment noting its purpose if it is a test/demo endpoint.

@fullsend-ai-review fullsend-ai-review Bot Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] scope-verification

Implementation matches issue #6 scope exactly: GET /foo returning {"result": "bar"} with tests and README documentation.

def foo():
return jsonify(result="bar")


_items_store = []


Expand Down
17 changes: 17 additions & 0 deletions test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,20 @@ def test_delete_item(client):
def test_delete_item_not_found(client):
resp = client.delete("/items/999")
assert resp.status_code == 404


def test_foo(client):
resp = client.get("/foo")
assert resp.status_code == 200
data = resp.get_json()
assert data == {"result": "bar"}


def test_foo_post_not_allowed(client):
resp = client.post("/foo")
assert resp.status_code == 405


def test_foo_delete_not_allowed(client):
resp = client.delete("/foo")
assert resp.status_code == 405
Loading