Add tracing spans - #4
Merged
Merged
Conversation
ff-team-sobrado
added a commit
that referenced
this pull request
May 5, 2026
…tionKey contract change Two amendments from Tomás's ADR review (PR #7): 1. Obs #1 — CI grep bypass via fully-qualified-name. The original pattern `import com.fasterxml.jackson` misses legal Java like `new com.fasterxml.jackson.databind.ObjectMapper()` (no import). Drop the `import` prefix; unanchored `com.fasterxml.jackson` catches both imports AND FQN uses. 2. Obs #4 — ReservationKey.fromStripeMetadata dual-shape parsing investigation. PaymentLambda's stripeMetadata helper writes every field as a String via Long.toString(...). Stripe metadata API contract is strings-only. The numeric-shape defensive branch in `requireLong` exists purely for test ergonomics (PaymentIntentSucceededHandlerTest uses ObjectNode.put(String, long) which produces a JSON numeric node). Migration PR drops the numeric branch in production code AND updates test fixtures to Long.toString(...) to match the production wire shape. Documented in the new "Notes from review" section. Co-Authored-By: Rui (Tech Lead) <team-sobrado@functorful.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few trace spans on the main methods called during the execution.