Roll back to 0.7.0 codebase (remove SubcategoryStructure), version 0.9.1#106
Open
Flummy1 wants to merge 1 commit into
Open
Roll back to 0.7.0 codebase (remove SubcategoryStructure), version 0.9.1#106Flummy1 wants to merge 1 commit into
Flummy1 wants to merge 1 commit into
Conversation
Completes the partial revert of the post-0.7.0 (v0.8.0) work. All files that diverged from 0.7.0 are restored to their 0.7.0 state, and the SubcategoryStructure feature is fully removed: - delete funpayparsers/types/subcategory_structure.py - remove SubcategoryFieldType from enums - drop field_schema / structured_fields / param_images - drop subcategory_id, subcategory_type, quantity, recipient and parse_title_fields from offer/order previews and pages - restore original parsers and import ordering Version is bumped to 0.9.1 (rollback shipped on top of 0.9.0), not lowered to 0.7.0.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the partial revert that the existing
Revert \"...\"commits started but left unfinished. The working tree is brought byte-for-byte to the 0.7.0 codebase, and the SubcategoryStructure feature is fully removed.The only intentional difference from the 0.7.0 tree is the package version, which is set to
0.9.1(rollback shipped on top of0.9.0, not lowered to0.7.0).What was removed (added after 0.7.0)
funpayparsers/types/subcategory_structure.py— deleted entirely (SubcategoryStructure,SubcategoryFieldDef,FieldCondition,_parse_title_fields)SubcategoryFieldTypeenum (types/enums.py)OfferFields.field_schemaOfferPage.structured_fields,OfferPage.param_imagesOfferPreview/OrderPreview:subcategory_id,subcategory_type,quantity,recipient,parse_title_fieldsOfferFieldsParser,OfferPreviewsParser, and the offer/my_offers/profile/subcategory page parsers__init__.pyfiles