Skip to content

Conversation

@skatsaounis
Copy link

This MR adds the following management commands:

  • createsuperuser_with_password: Gives the option to create superuser with password from the CLI
  • set_secret_key: sets the SECRET_KEY. It copies the existing functionality of patchman-manage
  • set_rdns_check: It sets rDNS check for hosts

@skatsaounis
Copy link
Author

Hi @furlongm, I am revisiting this PR since you appear to be active in Patchman again. Should I rebase to current develop and work on merging this PR? Do you find it a good idea?

@furlongm
Copy link
Owner

furlongm commented Sep 22, 2020

A rebase on develop would make it clearer what's in the PR.

For the commands, I'm not sure if they are better as part of the patchman cli or in a set of separate commands? I think the rdns option is already set there?

For setting the secret key, it's useful to be able to do that without the app being fully functional (like when installing from deb or rpm).

The createsuper command might also be useful there though.

So not sure where they should go really, or what is best practice in this case?

@skatsaounis skatsaounis force-pushed the add-management-commands branch from 4fa0b87 to 5bff794 Compare September 23, 2020 13:02
@skatsaounis
Copy link
Author

@furlongm I proceeded with the rebase.

The main reason behind these commands, is the Helm Chart I have already developed. Inside that Helm Chart, there are some Jobs which are using the Patchman Docker image to prepare Patchman deployment. For example, setting the secret key, applying migrations, creating superuser with password (this is needed as long as Patchman stays in Django < 3.0. They added it to Django > 3.0 https://docs.djangoproject.com/en/3.0/ref/django-admin/#createsuperuser)

@skatsaounis
Copy link
Author

@furlongm Hi Marcus. Did you have the chance to take a look here? This acts as a kind reminder.

furlongm and others added 29 commits April 23, 2025 19:59
Bumps [django](https://github.com/django/django) from 4.2.20 to 4.2.21.
- [Commits](django/django@4.2.20...4.2.21)

---
updated-dependencies:
- dependency-name: django
  dependency-version: 4.2.21
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [django](https://github.com/django/django) from 4.2.21 to 4.2.22.
- [Commits](django/django@4.2.21...4.2.22)

---
updated-dependencies:
- dependency-name: django
  dependency-version: 4.2.22
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.32.3...v2.32.4)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.32.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…-2.32.4

Bump requests from 2.32.3 to 2.32.4
Remove unused dependency 'chardet' from requirements.txt
Bumps [django](https://github.com/django/django) from 4.2.22 to 4.2.24.
- [Commits](django/django@4.2.22...4.2.24)

---
updated-dependencies:
- dependency-name: django
  dependency-version: 4.2.24
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
get_or_create_module only returns module
Package types are in the Package class
Bumps [django](https://github.com/django/django) from 4.2.24 to 4.2.25.
- [Commits](django/django@4.2.24...4.2.25)

---
updated-dependencies:
- dependency-name: django
  dependency-version: 4.2.25
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Set proxy settings from envars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants