renderer: drop incorrect minimax_m2 xfail; add renderer README#408
Open
Hecate0821 wants to merge 1 commit intomainfrom
Open
renderer: drop incorrect minimax_m2 xfail; add renderer README#408Hecate0821 wants to merge 1 commit intomainfrom
Hecate0821 wants to merge 1 commit intomainfrom
Conversation
The minimax_m2 parity case was marked xfail with the rationale
"renderer emits an extra '\n' after <think>". That rationale was
inferred from the empirical sweep (live gateway disagreed) and never
verified against HF — pytest.xfail() short-circuits before running
the comparison, so no one actually checked. Running the comparison
directly:
Renderer: ]~b]ai\n<think>\n (31 tokens)
HF template: ]~b]ai\n<think>\n (31 tokens) ← match ✓
Gateway: ]~b]ai\n<think> (30 tokens) ← gateway is the
odd one out
The renderer matches upstream HF byte-for-byte. The bug, if any,
lives in the Fireworks gateway's serving template for minimax-m2p7.
Drop the xfail marker so the parity test enforces the (already
correct) behaviour going forward; if the renderer ever drifts, the
test goes red instead of silently green.
Docs:
- training/renderer/README.md: new compact entry point that points
agents at the renderer + verifier skills and shows the verifier
token-stream screenshot.
- README.md: drop the "Renderer skills" section; the renderer
README now owns the entry point.
7/7 parity cases pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<think>vs HF/renderer's<think>\n). The right action is to keep the renderer as-is and let the test enforce parity going forward.Test plan
🤖 Generated with Claude Code