Skip to content

Validate unused reference infra config#411

Open
Hecate0821 wants to merge 1 commit intomainfrom
chengxi/reference-kl-validation
Open

Validate unused reference infra config#411
Hecate0821 wants to merge 1 commit intomainfrom
chengxi/reference-kl-validation

Conversation

@Hecate0821
Copy link
Copy Markdown
Collaborator

Summary

  • Fail fast when a reference job ID is supplied while needs_reference=False.
  • Fail fast when a reference training shape is supplied while needs_reference=False.
  • Add unit coverage for both validation paths.

Test Plan

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest training/tests/unit/test_infra_setup.py -q
  • python -m compileall -q training/utils/infra.py training/tests/unit/test_infra_setup.py
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant