fix: make GeoPoint portable through json - #56
Conversation
📝 WalkthroughWalkthroughAdds Firestore GeoPoint model support with database and JSON representations, exports the new helper through public Firestore modules, tests its transformations, and reformats helper documentation. Package manifest edits only adjust end-of-file formatting. ChangesFirestore GeoPoint support
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/effect-firebase/README.md`:
- Around line 37-46: Add the new Model.GeoPoint helper to the built-in field
helpers table in the README, including a concise description of its Firestore
geographic-point behavior consistent with the surrounding entries.
In `@packages/effect-firebase/src/lib/firestore/model/geopoint.ts`:
- Around line 1-4: Remove the unused Schema import from geopoint.ts while
preserving the Model, VariantSchema, and FirestoreSchema imports.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7d41de7a-c976-4ee5-8d8c-c7aad1d969d0
📒 Files selected for processing (10)
example/app/package.jsonexample/backend/package.jsonexample/shared/package.jsonpackage.jsonpackages/effect-firebase/README.mdpackages/effect-firebase/src/lib/firestore/firestore.tspackages/effect-firebase/src/lib/firestore/model/geopoint.spec.tspackages/effect-firebase/src/lib/firestore/model/geopoint.tspackages/effect-firebase/src/lib/firestore/model/index.tspackages/effect-firebase/src/lib/firestore/schema/geopoint.ts
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Make GeoPoint as portable as the other types
Summary by CodeRabbit
New Features
Tests
Documentation