Update Effect dependencies to 4.0.0-beta.103 and fix SchemaIssue API - #73
Conversation
Bump effect, @effect/atom-react, @effect/platform-browser, and @effect/vitest from 4.0.0-beta.99 to 4.0.0-beta.103 in the pnpm catalog. Adapt to the SchemaIssue.Forbidden constructor change, which no longer takes the actual value as its first argument. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbBpyYCQ1uyHAkiwdApVkZ
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe workspace updates selected Effect packages from beta.99 to beta.103. Firestore datetime and timestamp schemas adopt the revised ChangesEffect beta.103 compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR upgrades the Effect dependency family from 4.0.0-beta.99 to beta.103 and adapts Firestore timestamp decoding to the revised
Confidence Score: 4/5The incompatible @effect/vitest and Vitest versions should be aligned before merging. The dependency upgrade records @effect/vitest 4.0.0-beta.103, whose declared Vitest peer range starts at 4.1.0, while every workspace installation still resolves Vitest 4.0.9. Files Needing Attention: pnpm-workspace.yaml and pnpm-lock.yaml
|
| Filename | Overview |
|---|---|
| pnpm-workspace.yaml | Upgrades the Effect catalog, but the new @effect/vitest version is incompatible with the workspace's existing Vitest 4.0.9 pin. |
| pnpm-lock.yaml | Resolves Effect beta.103 consistently while recording an unmet @effect/vitest peer requirement for Vitest ^4.1.0. |
| packages/effect-firebase/src/lib/firestore/model/datetime.ts | Correctly updates SchemaIssue.Forbidden construction and removes the now-unused Option import. |
| packages/effect-firebase/src/lib/firestore/schema/timestamp.ts | Correctly updates SchemaIssue.Forbidden construction and removes the now-unused Option import. |
Reviews (1): Last reviewed commit: "Update effect packages to 4.0.0-beta.103" | Re-trigger Greptile
Summary
This PR updates the Effect library dependencies to version 4.0.0-beta.103 and adapts the codebase to breaking changes in the
SchemaIssue.ForbiddenAPI.Key Changes
effect,@effect/atom-react,@effect/platform-browser,@effect/vitest) from 4.0.0-beta.99 to 4.0.0-beta.103Optionimport frompackages/effect-firebase/src/lib/firestore/schema/timestamp.tsOptionimport frompackages/effect-firebase/src/lib/firestore/model/datetime.tsSchemaIssue.Forbiddenconstructor calls to match new API:new SchemaIssue.Forbidden(Option.some(input), { message: '...' })new SchemaIssue.Forbidden({ message: '...' })Implementation Details
The
SchemaIssue.Forbiddenconstructor signature changed in the new Effect version, no longer requiring the first parameter (previously anOptionof the input value). This simplifies error construction while maintaining the error message context.https://claude.ai/code/session_01XbBpyYCQ1uyHAkiwdApVkZ
Summary by CodeRabbit
Bug Fixes
Chores