feat(admin): add onScheduleEffect wrapper for scheduled functions - #78
Draft
fwal wants to merge 1 commit into
Draft
feat(admin): add onScheduleEffect wrapper for scheduled functions#78fwal wants to merge 1 commit into
fwal wants to merge 1 commit into
Conversation
Adds an Effect wrapper around firebase-functions/v2/scheduler's onSchedule, following the same conventions as the other trigger wrappers (runtime in options, withSpan tracing, defect logging). Documents the new wrapper in the package README and the create-firebase-function skill. Closes #60 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AEWBZud3svoJnGZZUStRcu
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Summary
Adds an
onScheduleEffectwrapper aroundfirebase-functions/v2/scheduler'sonSchedule, so scheduled functions (cron jobs) can run inside Effect like the other triggers.Details
runtimein the options object (matchingonMessagePublishedEffect/onTaskDispatchedEffect, rather than the third-argument shape sketched in the issue),Effect.withSpan('onScheduleEffect')tracing, and defect logging vialogger.error.ScheduledEvent(jobName,scheduleTime).functions.ts, available asimport { onScheduleEffect } from '@effect-firebase/admin'.onSchedule)" section in the admin README, plus example and API reference entries in thecreate-firebase-functionskill.Validation
nx run @effect-firebase/admin:build✅nx run @effect-firebase/admin:lint✅nx run @effect-firebase/admin:test— 31/31 passing ✅🤖 Generated with Claude Code
https://claude.ai/code/session_01AEWBZud3svoJnGZZUStRcu
Generated by Claude Code