feat: add refresh button to manually update audio device list#438
Open
fadyehabamer wants to merge 2 commits into
Open
feat: add refresh button to manually update audio device list#438fadyehabamer wants to merge 2 commits into
fadyehabamer wants to merge 2 commits into
Conversation
- Added refreshOutputs() method in FxController to manually refresh device list - Added reload button (↻) in FxProView next to output device selector - Button triggers device list refresh when clicked
…ooltip and update project configurations
Author
|
@bvijay74 could you please review this PR in order to be accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Sometimes when connecting Bluetooth headphones, the app continues to output sound through the laptop speakers until the Bluetooth device is reconnected. This occurs because the device list is not automatically refreshed when new audio devices connect.
Solution
Adds a manual refresh button to re-fetch connected audio devices, addressing the issue where Bluetooth headphones may not be automatically detected when connected.
refreshOutputs()method inFxControllerto manually refresh the audio device list by queryingAudioPassthruFxProViewpositioned next to the output device dropdownChanges Made
fxsound/Source/GUI/FxController.h: AddedrefreshOutputs()method declarationfxsound/Source/GUI/FxController.cpp: ImplementedrefreshOutputs()to fetch and update device listfxsound/Source/GUI/FxProView.h: AddedButton::Listenerinterface andrefresh_button_memberfxsound/Source/GUI/FxProView.cpp: Implemented button UI, positioning, and click handlerTesting
Manual testing required:
Branch
feature/refresh-devices-button