fix: verify release checksums from artifact directory - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Repairs prerelease checksum verification without rewriting the immutable
v0.1.0-alpha.2tag, and advances the distributable preview tov0.1.0-alpha.3. Application behavior is unchanged from alpha.2.Root cause
The workflow generated basename-only checksum entries while inside
dist/, then verified those entries from the repository root. Verification therefore could not locate the already-built wheel and source archive.Changes
../SHA256SUMSfrom insidedist/Verification
./scripts/check.sh: 2,080 tests, 100% statement/branch coverage, Ruff, format, strict mypy, architecture/contract/docs/OpenAPI/build/secret/dependency gatesuv buildwheel + source archive probeshasum -a 256 -c ../SHA256SUMS: both artifacts OKCloses #54