fix(fuzz): drop a statically dead null guard in the markdown oracle - #20
Merged
Conversation
CodeQL #128 (js/comparison-between-incompatible-types): extractFrontmatter returns an object literal on every path, so `result == null` can never be true and the comparison is dead. It also bought nothing. Had it ever returned null, the property reads that follow would throw a TypeError, which the fuzzer reports as a crash exactly the same way. The assertions that carry the contract — body is a string, body is never longer than the input, a declined parse leaves the body untouched — are unchanged. Re-fuzzed after the edit: 610,641 executions, no crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL #128 (
js/comparison-between-incompatible-types).extractFrontmatterreturns an object literal on every path, soresult == nullcan never be true — the comparison is statically dead.It also bought nothing: had it ever returned null, the property reads that follow throw a
TypeError, which the fuzzer reports as a crash exactly the same way. The assertions carrying the actual contract are unchanged — body is a string, body is never longer than the input, and a declined parse leaves the body untouched.Re-fuzzed after the edit: 610,641 executions, no crashes.