Fix image context on text follow-up turns#22
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
A recent Ollama tool-calling fix changed image history selection so image bytes were only included when the current turn attached a new image. A user could upload an image, receive a reply, then ask a text-only follow-up about that image; the provider payload would contain only a placeholder note instead of the actual prior image. This silently broke multi-turn vision Q&A across vision providers.
Root cause
execute_chat_turngated the latest image turn selection onpending_image.is_some(). On text-only follow-ups,image_turn_idbecameNone, causingchat_turn_from_stored_with_image_policyto strip all stored image payloads from recent context.Fix
Restored the invariant that the latest user image in recent history remains attached for provider context, while preserving the separate
current_turn_has_imageflag used for Ollama tool gating. Added a focused Rust regression test for the selector.Also gated the Windows-only WSL bash shim unit test to Windows so Linux validation can run cleanly.
Validation
cargo test latest_user_image_turn_stays_available_for_text_followupscargo test