Fix Windows builds#156
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows builds
Details
Consolidated Interfaces: Defined CommandExecutor and WindowsProcessChecker in process.go using platform-neutral types (uintptr for Windows handles) to prevent build failures on non-Windows systems.
Unified ProcessManager: Updated the ProcessManager struct to use these shared interfaces, replacing the temporary any types and removing redundant local definitions in process_unix.go and process_windows.go.
Platform Harmonization:
Updated process_windows.go to implement the new uintptr-based interfaces.
Renamed commandWrapper to realCommandExecutor in process_unix.go for consistency across the codebase.
Updated Tests: Refactored both process_unix_test.go and process_windows_test.go to align with the new interface signatures and mock structures.
Test Results
Linux Build: go build ./internal/cli/platform/... - PASSED
Windows Cross-Build: GOOS=windows go build ./internal/cli/platform/... - PASSED
Unit Tests: go test ./internal/cli/platform/... - PASSED (all tests green)