Fix empty git bug - #11
Merged
Merged
Conversation
Git 2.47.0 introduced a new feature which spawns a detached `git maintenance run` in the background. This can result in a problem because it creates a `maintenance.lock` file. The current IsEmpty implementation then interprets that incorrectly. One option is to disable this with the config `maintenance.auto=false` but I think it's more safe to just check if `.git` exists and contains at least one commit ref. But we should keep that feature in mind when using concurrency on the same repository! See also argoproj/argo-cd#25101
flecno
force-pushed
the
fix-empty-git-bug
branch
from
August 20, 2026 22:23
dd8c458 to
ea669be
Compare
flecno
force-pushed
the
fix-empty-git-bug
branch
from
August 20, 2026 22:28
ea669be to
76560c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git 2.47.0 introduced a new feature which spawns a detached
git maintenance runin the background. This can result ina problem because it creates a
maintenance.lockfile.The current
IsEmptyimplementation then interprets that incorrectly.One option is to disable this with the config
maintenance.auto=falsebut I think it's more safe to just check if.gitexists and contains at least one commit ref.But we should keep that feature in mind when using concurrency on the same repository!
See also argoproj/argo-cd#25101