Integrate operations from the Notification API#472
Integrate operations from the Notification API#472heisner-tillman wants to merge 49 commits intogalaxyproject:mainfrom
Conversation
359804e to
8bbd6e6
Compare
bernt-matthias
left a comment
There was a problem hiding this comment.
Can you try to rebase? Maybe this solves the test problems.
Done. |
|
Tests fail. Guess you need to add Line 69 in fe48906 |
|
Green! 🍏 |
8b3880d to
2199b52
Compare
316c21c to
a1f38e5
Compare
03358e4 to
aa11330
Compare
…_status operation
…fications for testing
…ferences operation
aa11330 to
7a83ae7
Compare
|
The root of the problem seems to be that from 24.1 notifications are handled by celery and a POST request to /api/notifications returns AsyncTaskResultSummary (or NotificationCreatedResponse) To make these tests pass I could disable celery (is it possible to disable certain tasks only?) .. but this breaks many other tests. |
|
Instead of disabling Celery, I suggest using the async flow. When sending a notification, we just need to poll on |
This reverts commit 7d03c6f.
a915e5d to
bdce6a8
Compare
bdce6a8 to
31ed6ba
Compare
|
I changed the tests accordingly (therefor I added the tasks API). I tested manually that the tests also work for a non-celery setup. |
f9e70ac to
a1e9cfd
Compare
This is a part of #471
Summary
How to test the changes
Run the corresponding test file:
bioblend/_tests/TestGalaxyNotifications.py