[26.0] Fix sample sheet upload without sample-sheet-specific columns #22488
Open
mvdbeek wants to merge 1 commit intogalaxyproject:release_26.0from
Open
[26.0] Fix sample sheet upload without sample-sheet-specific columns #22488mvdbeek wants to merge 1 commit intogalaxyproject:release_26.0from
mvdbeek wants to merge 1 commit intogalaxyproject:release_26.0from
Conversation
When a collection typed as `sample_sheet` was populated without any column definitions (or with an empty list), `validate_row` raised `RequestParameterInvalidException: Sample sheet row is missing` because the early-return only triggered on `column_definitions is None` and `generate_elements` unconditionally required a rows dict. Treat missing/empty column_definitions as list-like: skip row validation and synthesize per-identifier `None` rows. Refs galaxyproject#22487
jmchilton
approved these changes
Apr 15, 2026
mvdbeek
changed the title
github-actions
bot
added
area/testing
area/database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a collection typed as
sample_sheetwas populated without any column definitions (or with an empty list),validate_rowraisedRequestParameterInvalidException: Sample sheet row is missingbecause the early-return only triggered oncolumn_definitions is Noneandgenerate_elementsunconditionally required a rows dict.Treat missing/empty column_definitions as list-like: skip row validation and synthesize per-identifier
Nonerows.Refs #22487
How to test the changes?
(Select all options that apply)
License