Skip to content

updating transactions#24

Open
ayinot wants to merge 2 commits intogallactic:masterfrom
ayinot:master
Open

updating transactions#24
ayinot wants to merge 2 commits intogallactic:masterfrom
ayinot:master

Conversation

@ayinot
Copy link
Copy Markdown
Contributor

@ayinot ayinot commented Feb 22, 2019

refactored the transaction class to match with the intergallactic library

Comment thread README.md

bond|bnd [options] <public_key> <amount> <fee> <priv_key>
(safe) Do Bond transaction, you need pass the validator publickey, stake amount, transaction fee, and private key of sender
bond|bnd [options] <public_key> <amount> <priv_key>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove fee from these txs?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ToniyaSundaram removed it, because currently intergallactic don't support fee feature yet

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f Yes it is in accordance with intergallactic

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fee = OutAmount - InAMount.
I think gnet should handle it. not intergallactic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants