Add initial version of games catalog#753
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
||
| [tool.setuptools] | ||
| packages = ["pygambit", "pygambit.catalog"] | ||
| package-dir = { "pygambit" = "src/pygambit", "pygambit.catalog" = "catalog" } |
There was a problem hiding this comment.
This is how we get the pygambit.catalog module to be built using code from catalog dir at the root of the repo
| package-dir = { "pygambit" = "src/pygambit", "pygambit.catalog" = "catalog" } | ||
|
|
||
| [tool.setuptools.package-data] | ||
| "pygambit.catalog" = ["*"] |
There was a problem hiding this comment.
This is how the catalog files get included as package data
|
Also, a question for reviewers: Will there only ever be a single game file in the catalog for games that can be represented in both normal and extensive form? For example, in If not I would need a type argument for the load function for cases where we have nfg and efg versions of a game |
Issues closed by this PR
Description of the changes in this PR
This PR adds infrastructure and documentation for a first version of the Catalog of games:
catalogdircatalogdir)contrib/gamestocatalogto test catalog functionalitysrc/pygambit/update_catalog.pythat you run after adding a new EFG/NFG (usage described in developer docs)How to review this PR