Update bundled gems, upgrade to support ruby 3.4.2#46
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the gem to support Ruby 3.4.2 and addresses dependency changes. The changes primarily involve updating quoted string patterns in test files to match Ruby 3.4.2's error message format, adding the 'observer' gem dependency, and updating version references.
- Updated test expectations to use single quotes instead of backticks in error message patterns
- Added 'observer' gem as a runtime dependency to support Ruby 3.4.2
- Updated Ruby version references and CI matrix to include newer Ruby versions
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/lib/LittleWeasel/modules/region_spec.rb | Updated error message expectations to use single quotes |
| spec/lib/LittleWeasel/modules/locale_spec.rb | Updated error message expectations to use single quotes |
| spec/lib/LittleWeasel/modules/language_spec.rb | Updated error message expectations to use single quotes |
| lib/LittleWeasel/version.rb | Bumped version from 5.0.13 to 5.0.14 |
| LittleWeasel.gemspec | Added 'observer' gem as runtime dependency |
| CHANGELOG.md | Added changelog entry for version 5.0.14 |
| .ruby-version | Updated Ruby version from 3.0.1 to 3.4.2 |
| .github/workflows/ruby.yml | Expanded CI matrix to test against additional Ruby versions |
LittleWeasel.gemspec
Outdated
| spec.required_ruby_version = Gem::Requirement.new('>= 3.0.1', '< 4.0') | ||
|
|
||
| spec.add_runtime_dependency 'activesupport', '>= 7.0.8', '< 8.0' | ||
| spec.add_runtime_dependency 'observer' |
There was a problem hiding this comment.
The 'observer' dependency is missing a version constraint. Consider adding version constraints for consistency and to prevent potential compatibility issues, e.g., 'observer', '~> 0.1'.
| spec.add_runtime_dependency 'observer' | |
| spec.add_runtime_dependency 'observer', '~> 0.1' |
CHANGELOG.md
Outdated
| * Changes | ||
| * Update gems. | ||
| * Add 'observer' gem to dependencies. | ||
| * enhancements |
There was a problem hiding this comment.
The word 'enhancements' should be capitalized to match the formatting of other changelog sections (e.g., 'Changes').
| * enhancements | |
| * Enhancements |
gangelo
force-pushed
the
development
branch
4 times, most recently
from
e7ad7f5 to
1ab2710
Compare
No description provided.