Implemented a more refined version of the two-closure computation#10
Open
JHahnHRO wants to merge 1 commit intogap-packages:masterfrom
JHahnHRO:twoClosureComputation
Open
Implemented a more refined version of the two-closure computation#10JHahnHRO wants to merge 1 commit intogap-packages:masterfrom JHahnHRO:twoClosureComputation
JHahnHRO wants to merge 1 commit intogap-packages:masterfrom
JHahnHRO:twoClosureComputation
Conversation
…t does not use ALL orbital graphs.
Collaborator
|
The steps are revering to https://github.com/JHahnHRO/LaTeX/blob/master/Stuff-about-orbital-graphs/orbital_graphs.pdf |
Member
|
Did you try comparing the runtimes of this function with runtimes of the original function? What happens if you just stupidly use edge-coloured graphs? If you do benchmarks, please provide the examples and timings. |
markuspf
reviewed
Mar 19, 2019
| G -> Intersection(List(OrbitalGraphs(G), AutomorphismGroup)) ); | ||
| # TODO: TwoClosure as implemented by Heiko Theißen requires the group | ||
| # to be transitive. | ||
| # to be transitive. |
Author
There was a problem hiding this comment.
No particular reason. It's just whitespace in a comment, didn't think about it much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original algorithm simply intersects the automorphism groups of (almost) ALL orbital graphs. That really isn't necessary, most orbital graphs do not contribute anything new to the intersection. This new algorithm uses computations inside the endomorphism algebra of the permutation module to cut down on the number of necessary orbital graphs and should therefore be much faster.