Open
Conversation
wilfwilson
force-pushed
the
faster-orbital-graphs
branch
from
8b77636 to
324cd41
Compare
wilfwilson
force-pushed
the
faster-orbital-graphs
branch
from
324cd41 to
2b3555d
Compare
wilfwilson
force-pushed
the
faster-orbital-graphs
branch
from
2b3555d to
a3d2141
Compare
This comment has been minimized.
This comment has been minimized.
wilfwilson
force-pushed
the
faster-orbital-graphs
branch
3 times, most recently
from
c5636de to
0465bf0
Compare
wilfwilson
force-pushed
the
faster-orbital-graphs
branch
from
0465bf0 to
3ecaa6f
Compare
Member
Author
|
I'm unlikely to continue work on this at any near point in the near future, but let's see. I'll keep this open for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge this yet, I'm still playing around with some ideas.
Note that on my computer, the test file
tst/orbitalgraphs.tstnow takes about 75 milliseconds rather than 1 second.The results are currently slightly different (and therefore the tests are failing) because my new code is not returning some 'trivial' orbit graphs (i.e. such as orbital graphs where one or both of the base points is fixed).