Merge OrbitalGraphs with _BTKit.getOrbitalList so that BacktrackKit can use OrbitalGraphs#44
Open
wilfwilson wants to merge 2 commits intogap-packages:masterfrom
Open
Conversation
wilfwilson
force-pushed
the
replace_BTKit.getOrbitalList
branch
from
079bc7a to
0709bc7
Compare
This way, _BTKit.getOrbitalList can be removed from the BacktrackKit package, and BacktrackKit can rely on the OrbitalGraphs package instead. This reduces code duplication and gives further motivation to improve the OrbitalGraphs package.
wilfwilson
force-pushed
the
replace_BTKit.getOrbitalList
branch
from
0709bc7 to
c968511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also pretty much merged
OrbitalGraphswith ferret's_YAPB_getOrbitalList. Perhaps we will also eventually get ferret to useOrbitalGraphs, too.This is some progress towards #40.