Beta-1 Achievements Fixes

[sunlollyking]

Description

Post-review bug fixes and improvements to the RetroAchievements integration, addressing issues found during community testing on LibreELEC and WSL2 builds.

Motivation and context

Bug fixes !

How has this been tested?

Tested on:

• LibreELEC on real hardware with an 8BitDo controller
• WSL2 Ubuntu (development)

Specific scenarios verified:

• Session remains active across multiple game loads without false expiry
• Game load notification shows correct game icon (not default Kodi icon)
• Achievement unlock notification shows badge image on first unlock
• Leaderboard dialog no longer flickers when not logged in
• Page up/down scrolling works in leaderboard entries dialog
• Notification icons are consistent (warning icon throughout)
• LE build compiles cleanly without HAS_WEB_SERVER

What is the effect on users?

• Session stability: Users will no longer be unexpectedly logged out due to transient network failures when loading games. The token is now only cleared on an explicit authentication error from the RA server.
• Notification images: Game icons and achievement badge images now always appear in notifications, including on first load (previously only showed after a second load once the image was cached).
• Leaderboard UX: Logged-out users no longer see a brief empty dialog flash before being shown the login prompt. Page up/down scrolling now works in the leaderboard entries list.
• Icon consistency: All RetroAchievements warning notifications now use the warning icon consistently.
• InfoLabel rename: RetroPlayer.AchievementsLoggedIn renamed to RetroPlayer.RetroAchievementsLoggedIn for clarity and consistency with the platform name.
• LE build: Fixed a preprocessor bug in NetworkServices.cpp that caused build failures on LibreELEC (HAS_LIBTORRENT defined without HAS_WEB_SERVER).

Screenshots (if appropriate):

Types of change

• [X ] Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• [X ] Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• Student submission (PR was done for educational purposes and will be treated as such)
• None of the above (please explain below)

Checklist:

• [X ] My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• [X ] I have read the Contributing document
• I have added tests to cover my change
• [X ] All new and existing tests passed

[garbear]

You should push fixes to #147. Checkout the branch, cherry-pick the commit, and push the branch. The PR will automatically update.

The webserver/kademlia commit isn't correct, try building with -DENABLE_KADEMLIA=OFF.

The fixes commit also has unrelated files, you probably shouldn't be pushing ROMs to GH when you can avoid it.

For the other fixes, try pushing one fix per commit. That makes it easier to review. If you're prompting, then just commit prompt-by-prompt instead of a single megaprompt.

Once the fixes are pushed to #147, this PR can be closed.

[garbear]

I force-push to retroplayer-beta1 branch, as you can see when the PR gets messed up with commits from the old branch. I created the retroachievements-base as a stable branch that you can PR against. I updated #147 to point to that branch.

[sunlollyking]

Ah apologies my mistake - I'll try fix this in a few hours!