prepare: rename output component-descriptor -> component-descriptor-artefact#1645
Open
ccwienk wants to merge 1 commit into
Open
prepare: rename output component-descriptor -> component-descriptor-artefact#1645ccwienk wants to merge 1 commit into
ccwienk wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
Bot
added
do-not-merge/needs-kind
ccwienk
force-pushed
the
feat/rename-cd-output
branch
from
9bb17f0 to
a83abb3
Compare
IndritFejza
reviewed
Jun 25, 2026
| version: ${{ steps.version.outputs.version }} | ||
| commit-digest: ${{ steps.version.outputs.commit-digest }} | ||
| component-descriptor: ${{ steps.component-descriptor.outputs.component-descriptor-artifact }} | ||
| component-descriptor-artefact: ${{ steps.component-descriptor.outputs.component-descriptor-artifact }} |
Member
There was a problem hiding this comment.
I have noticed a mix of usage of british/american artefact and artifect in the wf/actions in this repo.
Would it make sense to unify all usages and use only 1 term?
As to no cause confusion.
That could potentially cause breaking changes ofc.
ccwienk
removed
the
do-not-merge/needs-kind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
component-descriptorworkflow output ofprepare.yamltocomponent-descriptor-artefact, making it unambiguous that the value is anartifact name, not inline YAML (incompatible change).