sbom: add S3 scanning, restore mandatory cbomkit-theia, rename cbom format#1651
Merged
Conversation
…ormat - sbom/s3.py: S3 object download helper (stdlib only, no boto3) - sbom/inject.py: add scan_s3_resource + build_s3_sbom_ocm_resources; restore check_cbomkit_theia() as mandatory; restore hard failure in scan_image (revert try/except softening) - sbom/cbom.py, inject.py: rename cbom-format value cyclonedx-1.6 → cyclonedx-1.6+cbom (RFC 6838 structured-syntax suffix convention) - upload.py: simplify _fmt_id — cbom-format value is now self-descriptive - ctt/process_dependencies.py: call check_cbomkit_theia() pre-flight; wire inject_s3_sboms flag through to process_replication_plan_step
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
Bot
added
do-not-merge/needs-kind
ccwienk
removed
the
do-not-merge/needs-kind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sbom/inject.scan_s3_resource+build_s3_sbom_ocm_resources; downloads S3 objects using stdlib only (no boto3)check_cbomkit_theia()as a mandatory pre-flight check (reverts thetry/except softening from the
sbom-s3-scanningbranch)cbom-formatextraIdentity valuecyclonedx-1.6→cyclonedx-1.6+cbom(RFC 6838 structured-syntax suffix, aligns with
CBOM_ARTIFACT_TYPEwhich usesprofile=cbom)upload.py _fmt_id: CBOM format value is now self-descriptive, no prefix neededinject_s3_sbomsflag throughctt/process_dependencies.pyTest plan
ctt/test/process_deps_test.py— 11 tests pass (SBOM resource identity + format values)test/sbom/upload_fmt_test.py— format ID and filename tests pass with new cbom-format value