Skip to content

Merged diki config improvements to indentation and optional fields#745

Open
AleksandarSavchev wants to merge 2 commits into
gardener:mainfrom
AleksandarSavchev:fix/merge-output-formatting
Open

Merged diki config improvements to indentation and optional fields#745
AleksandarSavchev wants to merge 2 commits into
gardener:mainfrom
AleksandarSavchev:fix/merge-output-formatting

Conversation

@AleksandarSavchev

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
This PR does 2 minor improvements to diki config:

  • merged config have indentation set to 2, previously was 4
  • optional fields in diki config are now omitted when empty

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner June 23, 2026 09:19
@gardener-prow gardener-prow Bot added the kind/enhancement Enhancement, improvement, extension label Jun 23, 2026
@gardener-prow

gardener-prow Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dimityrmirchev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jun 23, 2026
@georgibaltiev

Copy link
Copy Markdown
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants