🌱 replace opentelemetry-operator with /apis sub-module v0.153.0#518
Open
nickytd wants to merge 1 commit into
Open
🌱 replace opentelemetry-operator with /apis sub-module v0.153.0#518nickytd wants to merge 1 commit into
nickytd wants to merge 1 commit into
Conversation
…/apis In v0.153.0 the OpenTelemetry Operator carved its API types out into a dedicated 'apis' sub-module (github.com/open-telemetry/opentelemetry-operator/apis). The carve-out has no dependency on sigs.k8s.io/controller-runtime, so it unblocks transitive controller-runtime bumps (e.g. #491, #501) that were breaking the parent module's webhook code: apis/v1beta1/collector_webhook.go:451:34: not enough arguments in call to ctrl.NewWebhookManagedBy have (controllerruntime.Manager) want (manager.Manager, T) gardener/logging only imports apis/v1beta1 (OpenTelemetryCollector type + AddToScheme), so the migration is transparent — same import path, slimmer dependency closure (~250 lines pruned from go.sum).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind bug
/area logging
/area dev-productivity
What this PR does / why we need it:
Replaces the
github.com/open-telemetry/opentelemetry-operatorv0.146.0 dependency with the carved-out sub-modulegithub.com/open-telemetry/opentelemetry-operator/apisv0.153.0.The OpenTelemetry Operator v0.153.0 release moved the
apis/package into a dedicated Go sub-module. The new sub-module has no dependency onsigs.k8s.io/controller-runtime— onlyk8s.io/api,k8s.io/apimachinery, and small utility libs.This repo only imports
apis/v1beta1(theOpenTelemetryCollectorCRD type andAddToScheme), so the import paths stay identical and no source changes are required.Which issue(s) this PR fixes:
Unblocks #491 and #501, both of which fail CI with:
The error is in the parent module's webhook code, which calls a controller-runtime API that became generic in newer versions. By switching to the
apissub-module we never compile that webhook file, so transitive controller-runtime bumps (e2e-framework→ 0.7.0 in #491,controller-runtime→ 0.24.1 in #501) no longer break us.Closes #491.
Special notes for your reviewer:
go.mod/go.sumonly — no source files touched.pkg/controller/otelcol_reconciler.goalready imports.../apis/v1beta1, which resolves to the new sub-module without any code change.go.sumshrinks by ~250 lines: the old parent module pulled in cert-manager, prometheus-operator, gateway-api, cel-go, openshift APIs, AWS/Azure SDKs, etc. — none of which we use.apissub-module declaresgo 1.26.0; this repo is already ongo 1.26.3, so the floor is satisfied.make verifyis clean locally (fmt, gci, go fix, full test suite).Release note: