Use correct types for custom operations#189
Open
SkySkimmer wants to merge 2 commits into
Open
Conversation
SkySkimmer
added a commit
to rocq-prover/platform
that referenced
this pull request
Apr 2, 2025
Contributor
Author
|
Not sure what's going on in CI but seems unrelated |
Collaborator
|
@SkySkimmer there are two classes of jobs:
The second set of tests, which is more exhaustive, is failing. Indeed that seems unrelated, so it shouldn't be a blocker for the merge. @garrigue , does the patch look OK to you, I'm happy to take care of the merge. Would you mind adding a changes entry @SkySkimmer , so a new release can be pushed? |
Owner
|
I don't think I am the author of these lines, so I'm not sure what the concrete problem is. |
Contributor
Author
|
The modified functions are used for https://github.com/ocaml/ocaml/blob/e0bd2767f9c52c93777b8084761cc675c6e40e9b/runtime/caml/custom.h#L32-L35 which uses uintnat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #188 (hopefully)