Skip to content

fix: connect engine in v0.29.1 migration#751

Open
alexandreroumieu-codeapprentice wants to merge 1 commit intogarrytan:masterfrom
alexandreroumieu-codeapprentice:fix/v0-29-1-pglite-connect
Open

fix: connect engine in v0.29.1 migration#751
alexandreroumieu-codeapprentice wants to merge 1 commit intogarrytan:masterfrom
alexandreroumieu-codeapprentice:fix/v0-29-1-pglite-connect

Conversation

@alexandreroumieu-codeapprentice
Copy link
Copy Markdown

@alexandreroumieu-codeapprentice alexandreroumieu-codeapprentice commented May 8, 2026

Summary

  • Connect the migration-created engine before using it in v0.29.1 backfill and verify phases.
  • Disconnect the engine in finally to release PGLite resources/locks.
  • Add a PGLite regression test covering phaseBBackfill and phaseCVerify via a temporary GBRAIN_HOME.

Root cause

phaseBBackfill and phaseCVerify called createEngine(...) but then used the returned PGLite engine without first calling engine.connect(engineConfig), causing:

PGLite not connected. Call connect() first.

Validation

  • bun test test/migration-v0-29-1.test.ts
  • bun run typecheck

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant