Open
Conversation
1. Automatic Java Detection - The script now automatically searches for the appropriate Java installation on the system, removing the need for manual configuration. - It first checks for the presence of Java 8 (Java 1.8) and sets the JAVA_HOME environment variable accordingly. 2. Custom Java Directory Support - Users can now specify a custom Java installation path by creating a file named java_path in the root directory of the JES installation. - This file should contain the full path to the desired Java installation, allowing for easy management of the Java version used by JES without modifying the system's global JAVA_HOME. 3. Line Ending Compatibility - The original jes.sh script required manual end-of-line conversion (using dos2unix) to be usable on Linux, as it was designed with Windows-style line endings (CRLF). - This version of the script eliminates the need for such conversion, ensuring compatibility with Linux systems that expect Unix-style line endings (LF).
Changes - It includes specific versioning, making it easier to track the version of JES. - It validates the presence of the icon file and provides error messages when necessary, preventing broken links. - It is clearer and more consistent in structure, with improved error handling and better user feedback. - It provides a more user-friendly experience by hardcoding the application title (JES), while ols version had unnecessary complexity with dynamic placeholders.
added explanation to how to add java 8 path for jes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jes.sh script rewrite + minor changes to make it usable on linux for students