Skip to content

Add option to disable blockquote formatting in cloned issues#231

Open
nmurrell07 wants to merge 1 commit intogatewayapps:masterfrom
nmurrell07:add-blockquote-option
Open

Add option to disable blockquote formatting in cloned issues#231
nmurrell07 wants to merge 1 commit intogatewayapps:masterfrom
nmurrell07:add-blockquote-option

Conversation

@nmurrell07
Copy link
Copy Markdown

Summary

This PR adds a new option to the Kamino settings that allows users to disable the automatic blockquote formatting when cloning GitHub issues. Previously, the addBlockQuote function would add > to every line of the issue body, which could interfere with template formatting.

Changes

  • options.html: Added a new checkbox "Add blockquote formatting to cloned issue description" (default: checked for backward compatibility)
  • options.js: Updated to save and restore the new addBlockquote setting
  • batch.js:
    • Added getAddBlockquoteSetting() function to retrieve the setting from storage
    • Modified createGithubIssue() to conditionally apply blockquote formatting based on user preference
    • Modified cloneOldIssueComments() to conditionally apply blockquote formatting to comments

Testing

The fix maintains backward compatibility by defaulting to the current behavior (adding blockquotes). Users can now disable this feature if they prefer to preserve the original formatting of their issue descriptions.

Related Issue

This addresses the issue where template formatting is broken by the automatic blockquote wrapping.

This fix addresses the issue where the addBlockQuote function adds
'>' to every line of the issue body, which interferes with template
formatting. Users now have the ability to disable this behavior via
a new checkbox in the settings.

Changes:
- Added 'add-blockquote' checkbox to options.html
- Updated options.js to save and restore the new setting
- Added getAddBlockquoteSetting() function to batch.js
- Modified createGithubIssue() to conditionally apply blockquote formatting
- Modified cloneOldIssueComments() to conditionally apply blockquote formatting

This allows users to choose whether to preserve the original formatting
of their issue descriptions or have them wrapped in blockquotes.
Copy link
Copy Markdown
Contributor

@johnmurphy01 johnmurphy01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty close. batch.js is used for batch cloning, an experimental feature that can be used when on the issue list page. The main code file is app.js and the add block quote option changes will need to be made there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants