This repository was archived by the owner on Oct 19, 2024. It is now read-only.
WIP - PHP 7 upgrade#68
Open
niccofyren wants to merge 10 commits into
Open
Conversation
c604a97 to
e16057c
Compare
e16057c to
c1870b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of bigger and smaller tweaks to get rid of PHP 7 warnings and notices. It doesn't take care of each one (more than enough work to go around), but things that seem breaking and encountered while browsing a few of the more common app routes.
Most notable 🧑🔧 :
splitreferencesUnrelated 🥕 :
I think the only way to properly verify this is to try to run it locally or in a stage environment, doing misc stuff and seeing where any critical errors are thrown. (Misc PHP 7 compatibility tools report no errors, but still a bunch of notices and warnings) To run locally you might have to remove the two git related lines from Dockerfile, to make sure it uses local files instead of master/another branch.