Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

WIP - PHP 7 upgrade#68

Open
niccofyren wants to merge 10 commits into
masterfrom
php-7-upgrade
Open

WIP - PHP 7 upgrade#68
niccofyren wants to merge 10 commits into
masterfrom
php-7-upgrade

Conversation

@niccofyren

@niccofyren niccofyren commented Oct 19, 2020

Copy link
Copy Markdown
Member

Lots of bigger and smaller tweaks to get rid of PHP 7 warnings and notices. It doesn't take care of each one (more than enough work to go around), but things that seem breaking and encountered while browsing a few of the more common app routes.

Most notable 🧑‍🔧 :

  • Got rid of various split references
  • Upgraded to newest CakePHP 2.10.x version (which has a bunch of PHP 7 tweaks alongside regular bug and security fixes)
  • Changed CakePHP to be installed via composer for smoother upgrade when needed
  • Fixed a couple of Dockerfile php extensions incompatibilities with PHP 7

Unrelated 🥕 :

I think the only way to properly verify this is to try to run it locally or in a stage environment, doing misc stuff and seeing where any critical errors are thrown. (Misc PHP 7 compatibility tools report no errors, but still a bunch of notices and warnings) To run locally you might have to remove the two git related lines from Dockerfile, to make sure it uses local files instead of master/another branch.

@niccofyren niccofyren force-pushed the php-7-upgrade branch 7 times, most recently from c604a97 to e16057c Compare November 1, 2020 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant