Conversation
Similar to the PaymentForwarder and needed for the same reason, but used the block merging rev share payment.
gd-0
reviewed
Sep 2, 2026
| /// CALLDATA LAYOUT: | ||
| /// Offset 0..3: [uint32 timestamp] (4 bytes) | ||
| /// Offset 4..23: Recipient 1 (20 bytes) | ||
| /// Offset 24..55: Amount 1 (32 bytes) |
Collaborator
There was a problem hiding this comment.
do we really need 32 bytes for amount? its in ETH. think a u128 is > total eth in the universe
Collaborator
There was a problem hiding this comment.
can you ask claude to tone down the comments here? quite hard to read 😅
Comment on lines
+87
to
+88
| // Refund remaining balance to msg.sender | ||
| selfbalance iszero exit jumpi |
| push0 [LOCK_SLOT] sstore | ||
| stop | ||
|
|
||
| refund_failed: |
Collaborator
There was a problem hiding this comment.
when is this realistically going to happen? aren't we paying this with an eoa?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the PaymentForwarder and needed for the same reason, but used the block merging rev share payment.