Subscribe to peer events before starting producers - #274
Merged
Merged
Conversation
Bronek
changed the base branch from
main
to
bronek/peer_inventory_by_identity
September 16, 2026 16:48
Bronek
added this pull request to stack #270
September 16, 2026 16:49
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
from
September 17, 2026 08:54
7c664e0 to
de9ba58
Compare
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
from
September 17, 2026 10:08
de9ba58 to
698ac47
Compare
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
2 times, most recently
from
September 17, 2026 12:34
dc8b5e1 to
8c1310a
Compare
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
from
September 17, 2026 12:35
8c1310a to
70fe784
Compare
Bronek
marked this pull request as ready for review
September 17, 2026 12:37
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
from
September 17, 2026 16:30
70fe784 to
f91dfb4
Compare
vladimir-ea
reviewed
Sep 17, 2026
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
from
September 18, 2026 09:39
f91dfb4 to
be0b3e4
Compare
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
2 times, most recently
from
September 18, 2026 10:12
ba1ca75 to
e2cf0e5
Compare
vladimir-ea
approved these changes
Sep 18, 2026
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
from
September 18, 2026 11:02
4523b62 to
c990121
Compare
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
from
September 18, 2026 11:33
c990121 to
6b70539
Compare
Connections established before the application boundary first reads PeerEvent can be absent from the Beacon API for their lifetime. Update Flux to the revision tagged v0.3.2 and subscribe in on_attach. Construct the boundary runner before starting producer tiles, while keeping its worker startup position and thread configuration. Add a regression test that publishes a connection before the boundary worker starts and checks the peer endpoint. It fails with an empty peer list when early subscription is disabled. Assisted-by: Codex:gpt-6-astra
Bronek
force-pushed
the
bronek/peer_inventory_startup
branch
from
September 18, 2026 11:41
6b70539 to
d937eba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peer connections established (in
NetworkTile) before the application boundary first readsPeerEventmay not be reported from the Beacon API for their lifetime.Update Flux to the revision tagged v0.3.2 and subscribe in
on_attach. Construct the boundary runner before starting producer tiles, while keeping its worker startup position and thread configuration.That makes all peer connections visible to
ApplicationBoundaryTile, fixing potentially inaccurate reporting.