Remove unused Engine API payload-body operations - #279
Merged
Merged
Conversation
Bronek
force-pushed
the
bronek/remove_GetPayloadBodiesByHash
branch
from
September 17, 2026 16:52
47d9cfe to
5984195
Compare
Bronek
marked this pull request as ready for review
September 17, 2026 16:52
Collaborator
|
this is a good change (to remove the unused apis) but this PR includes Ninas commit for validator lookups for some reason. If you can rebase onto main? |
Neither payload-bodies request has a production publisher. Remove ByHash and ByRange, their shared response, RPC handlers, capability entries, and the response converter with its dedicated tests. The by-hash request reserves 128 inline hashes in every EngineReq slot. On x86-64, EngineReq shrinks from 4,120 to 976 bytes. A compiled layout probe confirms the new Flux slot is 1,024 bytes, down from 4,160. EngineResp remains 88 bytes with a 128-byte slot. Rebuild and reattach spine observers with the node for the changed engine_reqs layout. Validation: just fmt, just clippy with all features, and just test (1,583 passed, 6 ignored). Socket tests required execution outside the sandbox. Independent review found no issues. Assisted-by: Codex:GPT-6
Bronek
force-pushed
the
bronek/remove_GetPayloadBodiesByHash
branch
from
September 18, 2026 10:41
5984195 to
bfbced9
Compare
Collaborator
Author
Thanks, rebased. |
vladimir-ea
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
GetPayloadBodiesByHashandGetPayloadBodiesByRange, their shared responseEngineGetPayloadBodiesResp, RPC handlers, capability entries, and the response converter with its dedicated tests. Neither payload-bodies request has a production publisher.The by-hash request reserves 128 inline hashes in every
EngineReqslot. On x86-64,EngineReqshrinks from 4,120 to 976 bytes. A compiled layout probe confirms the new Flux slot is 1,024 bytes, down from 4,160.EngineRespremains 88 bytes with a 128-byte slot.Rebuild and reattach spine observers with the node for the changed
engine_reqslayout.