fix: focus terminal on mobile app-mouse tap#152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On iOS, in Claude Code fullscreen/app-mouse mode, a clean tap forwarded the SGR click to the app and returned early — so
focusTerminalInput()never ran and the on-screen keyboard didn't activate. This focuses the xterm helper textarea on that tap path, keeping the focus tied to the livetouchenduser gesture (which iOS Safari requires) without double-sending a click to tmux/Claude.Regression introduced by the app-mouse tap path added in #151.
Changes
src/client/components/Terminal.tsx: callfocusTerminalInput()beforepreventDefault()in thesendTapClickToAppsuccess branch.src/client/__tests__/useTerminal.test.tsx: assertfocusCalls === 1on both the app-mouse tap path and the copy-mode tap path.Verification
bun run lint && bun run typecheck && bun run test— all green locally (lint 0 errors, typecheck clean, 908 pass / 0 fail).🤖 Generated with Claude Code