Conversation
…nt_mode Land the expand-side schema migrations for both SQLite and Postgres so the new columns exist before any Rust code uses them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Land the expand-side schema migrations for both SQLite and Postgres so the new columns exist before any Rust code uses them.
Risk
medium — Renaming a column is a one-way migration; the compaction_state FK fix changes an existing migration file which may confuse environments that already ran it.
Rationale
Schema migrations must precede the Rust code that references the new column names. Shipping them first gives on-call engineers time to validate the migration on staging. Reviewers should check that migration 018 (rename) is idempotent and that the compaction_state FK fix in migration 006/008 does not break environments where the old schema was already applied.
Files (6)
crates/streamhouse-metadata/migrations-postgres/008_compacted_topics.sqlcrates/streamhouse-metadata/migrations-postgres/018_rename_clerk_to_external_id.sqlcrates/streamhouse-metadata/migrations-postgres/019_deployment_mode.sqlcrates/streamhouse-metadata/migrations/006_compacted_topics.sqlcrates/streamhouse-metadata/migrations/016_rename_clerk_to_external_id.sqlcrates/streamhouse-metadata/migrations/017_deployment_mode.sql