[L2] Types + store layer: introduce DeploymentMode, rename clerk_id → external_id in Rust - #13
Open
gbram1 wants to merge 1 commit into
Conversation
…k_id → external_id in Rust Update all Rust types, metadata store implementations, and call sites so the codebase compiles against the new schema columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Update all Rust types, metadata store implementations, and call sites so the codebase compiles against the new schema columns.
Risk
low — Mechanical rename within a bounded crate; all callers are internal and the trait API change is additive (rename only, same semantics).
Rationale
Depends on L1 so the DB columns are present when the store layer writes them. This is a pure rename refactor — no behavior change. Reviewers should check that every
clerk_idreference is gone, thatDeploymentModeserializes correctly to 'self_hosted'/'byoc'/'managed', and that theMetadataStoretrait'sget_organization_by_external_idsignature change is correctly propagated to bothSqliteMetadataStoreandPostgresMetadataStore. Also removes the#[ignore]tag fromtest_topic_cache_invalidation_on_delete— reviewer should verify the FK fix in L1 actually makes this test pass.Files (12)
crates/streamhouse-metadata/src/types.rscrates/streamhouse-metadata/src/store.rscrates/streamhouse-metadata/src/postgres.rscrates/streamhouse-metadata/src/cached_store.rscrates/streamhouse-metadata/src/lib.rscrates/streamhouse-metadata/src/backup.rscrates/streamhouse-metadata/src/quota.rscrates/streamhouse-metadata/src/tenant.rscrates/streamhouse-metadata/tests/integration_tests.rscrates/streamhouse-kafka/examples/kafka_rate_limit_test.rscrates/streamhouse-kafka/examples/kafka_smoke_test.rscrates/streamhouse-kafka/src/server.rs