[L3] Auth refactor: rename ClerkAuth → OidcJwksAuth, add OIDC_ISSUER_URL env var fallback - #14
Open
gbram1 wants to merge 1 commit into
Conversation
…SSUER_URL env var fallback Replace the Clerk-specific auth module with a vendor-neutral OIDC/JWKS module and update all API surface that references it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Replace the Clerk-specific auth module with a vendor-neutral OIDC/JWKS module and update all API surface that references it.
Risk
medium — Renames the public ClerkAuth export (breaking for any downstream binary referencing it) and removes the
require_adminguard on agent/metrics endpoints, which is a meaningful access-control change.Rationale
Depends on L2 because
handlers/organizations.rsnow referencesDeploymentModeandexternal_id. The file renameclerk.rs → oidc.rsis the dominant change inoidc.rs. Reviewers must pay attention to: (a) theOIDC_ISSUER_URL/CLERK_ISSUER_URLfallback logic inOidcJwksAuth::from_env; (b) removal ofrequire_adminfrom agents/metrics handlers — the rationale is that auth middleware now covers these, but the reviewer should verify those routes are behindSmartAuthLayerorAuthLayerinlib.rs; (c) the protobuf validation improvement inproduce.rsand schema registry, which logically belong to a separate concern but cannot be split without hunk-level splits — called out here.Files (15)
crates/streamhouse-api/src/oidc.rscrates/streamhouse-api/src/auth.rscrates/streamhouse-api/src/lib.rscrates/streamhouse-api/src/bin/api.rscrates/streamhouse-api/src/handlers/agents.rscrates/streamhouse-api/src/handlers/metrics.rscrates/streamhouse-api/src/handlers/topics.rscrates/streamhouse-api/src/handlers/organizations.rscrates/streamhouse-api/src/handlers/produce.rscrates/streamhouse-api/tests/api_integration_test.rscrates/streamhouse-schema-registry/src/registry.rscrates/streamhouse-schema-registry/tests/integration_test.rscrates/streamhouse-agent/tests/lease_coordination_test.rsdocker-compose.prod.ymldocs/authentication.md