Do not treat input as regex#45
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the CLI dispatch logic in cli_init.sh so that user-supplied command/subcommand strings are no longer interpreted as regular expressions when matching against discovered scripts. It also fixes a stderr inconsistency in the ambiguous-subcommand listing.
Changes:
- Replace regex
grep "${cmd2}.sh$"with awk basename equality to find an exact subcommand match. - Replace regex
grep "/${cmd}$"withgrep -Fxfixed full-line match for exact command directory match. - Send the ambiguous-subcommand listing in
run_command()to stderr, consistent withlist_commands().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.